Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #621

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

add task solution #621

wants to merge 11 commits into from

Conversation

DimaDamage91
Copy link

@DimaDamage91
Copy link
Author

Перевіряти поки не потрібно) Дякую!

etojeDenys
etojeDenys suggested changes Mar 13, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@DimaDamage91 DimaDamage91 requested a review from etojeDenys March 26, 2025 09:17
etojeDenys
etojeDenys suggested changes Mar 26, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. do not overlap menu
image
  1. it's always better to add some hover to links
image

@DimaDamage91 DimaDamage91 requested a review from etojeDenys March 26, 2025 14:32
volodymyr-soltys97
volodymyr-soltys97 suggested changes Mar 26, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Need to remove scroll when the menu is open
image
  1. The menu at the bottom does not have a blackout as in the design
image
  1. The image on the right should not have any indentation.
image
  1. Add hover effects for all clickable elements
image

volodymyr-soltys97
volodymyr-soltys97 approved these changes Mar 28, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimaDamage91 @volodymyr-soltys97 @etojeDenys