Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #633

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #633

wants to merge 3 commits into from

Conversation

bbbozhena
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Apr 4, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add hover effects for all clickable elements
image
  1. Add position fixed for the menu and fix the background color
image
  1. The images shouldn't overlap each other when hovering
image

etojeDenys
etojeDenys suggested changes Apr 7, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. should be links with some hover
image
  1. burger menu looks different
image image
  1. fonts looks different
image image

@bbbozhena bbbozhena requested a review from etojeDenys April 8, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbbozhena @volodymyr-soltys97 @etojeDenys @anastasiiavorobiova