-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
develop #5480
base: master
Are you sure you want to change the base?
develop #5480
Conversation
OlgaDnepr
commented
Mar 10, 2025
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission! Your code is well-structured and meets many of the task requirements. However, there are a couple of critical issues that need to be addressed before we can approve the pull request:
-
File Structure: Each BEM block should have its own separate file. Currently, both the HTML and CSS are in single files (
index.html
andstyle.css
). This does not adhere to the requirement and needs to be corrected. -
HTML Semantic Tags: While your HTML structure is solid, it could benefit from using more semantic tags instead of generic
div
elements. This will improve the readability and accessibility of your code.
Once these issues are addressed, your submission will be ready for approval. Keep up the great work, and don't hesitate to reach out if you have any questions! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/style.css
Outdated
/* .stars__star + .stars__star { | ||
margin-left: 4px; | ||
} */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented-out CSS rule for adding margin between stars is not currently in use. If spacing between stars is not needed, consider removing this section to keep the code clean. If you plan to use it later, it's fine to leave it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on addressing some of the previous issues! 🎉 While your solution is approved to help you move forward with your learning, there are still some important points to address:
-
File Structure: Ensure each BEM block has its own separate file for both HTML and CSS. This will help maintain a clean and organized codebase.
-
HTML Semantic Tags: Enhance your code's accessibility and readability by using semantic tags like
<section>
,<article>
, or<nav>
instead of genericdiv
elements. -
CSS Cleanliness: Remove any unnecessary commented-out styles to keep your CSS clean and maintainable.
These improvements are crucial for adhering to best practices and will greatly benefit your future projects. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<div class="box-stars"> | ||
<div class="stars stars--0"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--1"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--2"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--3"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--4"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--5"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current HTML structure does not follow the BEM methodology as required. Each BEM block should be in its own separate file. Consider restructuring your HTML to adhere to this requirement.
<div class="box-stars"> | ||
<div class="stars stars--0"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--1"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--2"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--3"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--4"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--5"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using more semantic HTML tags instead of generic div
elements to improve accessibility and readability. For example, using <section>
, <article>
, or <nav>
where appropriate.
.box-stars { | ||
display: flex; | ||
flex-direction: column; | ||
|
||
/* justify-content: space-between; */ | ||
|
||
/* width: 96px; | ||
height: 116px; */ | ||
|
||
/* padding: 22px; */ | ||
|
||
background: #fff; | ||
} | ||
|
||
.stars { | ||
display: flex; | ||
|
||
/* justify-content: space-between; */ | ||
} | ||
|
||
.stars__star { | ||
background-image: url(images/star.svg); | ||
width: 16px; | ||
height: 16px; | ||
background-repeat: no-repeat; | ||
background-position: center; | ||
margin: 0 4px 0 0; | ||
} | ||
|
||
.stars--1 .stars__star:nth-child(-n + 1), | ||
.stars--2 .stars__star:nth-child(-n + 2), | ||
.stars--3 .stars__star:nth-child(-n + 3), | ||
.stars--4 .stars__star:nth-child(-n + 4), | ||
.stars--5 .stars__star:nth-child(-n + 5) { | ||
background-image: url(images/star-active.svg); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current CSS structure does not follow the BEM methodology as required. Each BEM block should have its own separate CSS file. Consider restructuring your CSS to adhere to this requirement.
/* justify-content: space-between; */ | ||
|
||
/* width: 96px; | ||
height: 116px; */ | ||
|
||
/* padding: 22px; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several commented-out styles. If these styles are not needed, consider removing them to keep the CSS clean and maintainable.