add task solution #5485
add task solution #5485
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your code meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request:
-
Universal Selector Usage: The use of the universal selector
*in your CSS to reset margins can lead to performance issues. It's important to target specific elements instead. -
Separate Files for BEM Blocks: The task requires each BEM block to have its own separate CSS file. This is crucial for maintaining a clean and scalable codebase.
-
Invalid CSS Property: The
justify-content: left;property is not valid. Please usejustify-content: flex-start;to align items to the left in a flex container.
Please address these issues to ensure your code aligns with the task requirements. Once these changes are made, we can proceed with the approval. Keep up the great work, and don't hesitate to reach out if you have any questions! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/style.css
Outdated
|
|
||
| .stars { | ||
| display: flex; | ||
| justify-content: left; |
There was a problem hiding this comment.
The justify-content: left; property is not valid. You should use justify-content: flex-start; to align items to the left in a flex container.
There was a problem hiding this comment.
Great job on addressing the previous issues! 🎉 Your implementation now meets the task requirements, with each BEM block having its own CSS file and the justify-content property correctly set to flex-start. The universal selector has been removed, and the CSS for each stars--N block correctly targets the first N stars. While the code is approved, remember to always double-check that each CSS file corresponds to a specific BEM block. Keep up the good work and continue refining your skills! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
No description provided.