Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #5491

wants to merge 2 commits into from

Conversation

EtienneD10
Copy link

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • [ x ] Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • [ x ] Each BEM block has its own separate file
  • [ x ] All Typical Mistakes from BEM lesson theory are checked.
  • [ x ] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Pull Request has been approved! 🎉 Great job on implementing the 'Stars' page with a well-organized HTML structure and effective CSS styling. Here are some key points to consider for improvement:

  • CSS Selector Usage: Although you correctly avoided using the gap property, remember to maintain good practices by avoiding the universal selector (*) for performance reasons.

  • BEM and File Structure: While you followed BEM conventions with class naming, it's important to separate each BEM block into its own CSS file. This will help in maintaining a clean and organized codebase.

  • Image Usage: Excellent work using background-image for the stars, adhering to the task requirements.

To summarize, the main area for improvement is the separation of CSS files for each BEM block. Addressing this will enhance your code organization and maintainability.

Keep up the great work and continue to refine your skills! Remember, addressing these issues will help you grow as a developer. If you have any questions or need further clarification, feel free to reach out. Happy coding! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants