add task solution #5495
add task solution #5495
Conversation
There was a problem hiding this comment.
Hi! 👋 There are a couple of issues that need addressing before this PR can be approved. First, the HTML indentation in src/index.html needs to be corrected to improve readability. Second, the style.css should only contain @import './stars.css';, you shouldn't be importing other star styles here. Fix these and we're good to go! You're almost there! 😉
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
🤖 If you have any comments on my review, please leave a message in the Add a comment field and mention me with @mateacademy-ai-mentor. I will take your feedback into account in the next review.
src/styles/stars.css
Outdated
| .stars--1 .star:nth-child(-n + 1) { | ||
| background: url(../images/star-active.svg) no-repeat center; | ||
| } | ||
|
|
||
| .stars--2 .star:nth-child(-n + 2) { | ||
| background: url(../images/star-active.svg) no-repeat center; | ||
| } |
There was a problem hiding this comment.
| .stars--1 .star:nth-child(-n + 1) { | |
| background: url(../images/star-active.svg) no-repeat center; | |
| } | |
| .stars--2 .star:nth-child(-n + 2) { | |
| background: url(../images/star-active.svg) no-repeat center; | |
| } | |
| .stars--1 .star:nth-child(-n + 1), | |
| .stars--2 .star:nth-child(-n + 2) { | |
| background: url(../images/star-active.svg) no-repeat center; | |
| } |
combine all those selectors with comma
|
я випадково запросив ментора, вибачте( |
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All Typical Mistakes from BEM lesson theory are checked.
Code follows all the Code Style Rules ❗️