Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stars develop commit #5496

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

stars develop commit #5496

wants to merge 2 commits into from

Conversation

antmen71
Copy link

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 Thanks for your submission. While the HTML structure and CSS styling for the stars look good, we need to make a few adjustments before merging. Specifically, please add empty lines between your div elements in the HTML and create a separate CSS file for the stars block. Also, make sure the code follows all the style rules in the checklist. Once these are addressed, we'll be good to go! 😉 Keep up the great work!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

🤖 If you have any comments on my review, please leave a message in the Add a comment field and mention me with @mateacademy-ai-mentor. I will take your feedback into account in the next review.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've reviewed the code. There are a few minor issues: In src/index.html, you're missing empty lines between multiline sibling blocks of HTML. In src/style.css, the style is applied to the div element, but you shouldn't use tag names for styling (except html and body). The code doesn't follow all the Code Style Rules ❗️. I'm approving this pull request to keep you moving forward, but please take a look at the comments and improve your code based on them.

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +1 to +3
html,
body,
div {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, you should not use tag names for styling, except for html and body. Consider removing the div selector to comply with this rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants