-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5499
base: master
Are you sure you want to change the base?
add task solution #5499
Conversation
DmutroSheva
commented
Mar 14, 2025
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 Thanks for submitting your solution! Based on the review, a few key things need adjustments: 1) Each BEM block should be in its own separate file. 2) We need to use background-image
for the stars instead of the content
property. 3) The task requires to use stars__star
elements instead of pseudo-elements. 4) Avoid adding extra classes like stars--0
to the elements. Making these changes will align the code with the task requirements. Keep up the great work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
🤖 If you have any comments about this review, please leave a message in the Add a comment field below and mention me with @mateacademy-ai-mentor
tag. I will read your message when I perform the next review of your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉 The HTML structure with stars
blocks and modifiers is well-implemented, and the CSS for the stars looks good! However, please review the comments to address the formatting issues, especially adding empty lines between sibling HTML blocks for better readability. Also, make sure all the required modifiers (stars--0
to stars--5
) are present in the HTML. It's also important to separate each BEM block into its own CSS file and use 2 spaces for indentation in the CSS file. Keep up the good work, and remember to learn from the feedback provided to further improve your coding skills!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line here to improve readability, as per the HTML formatting guidelines in the checklist.
Add empty lines between multiline sibling blocks of HTML
To add some "air" and simplify reading. But don't add them between parent and child elements.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line here to improve readability, as per the HTML formatting guidelines in the checklist.
Add empty lines between multiline sibling blocks of HTML
To add some "air" and simplify reading. But don't add them between parent and child elements.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line here to improve readability, as per the HTML formatting guidelines in the checklist.
Add empty lines between multiline sibling blocks of HTML
To add some "air" and simplify reading. But don't add them between parent and child elements.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line here to improve readability, as per the HTML formatting guidelines in the checklist.
Add empty lines between multiline sibling blocks of HTML
To add some "air" and simplify reading. But don't add them between parent and child elements.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line here to improve readability, as per the HTML formatting guidelines in the checklist.
Add empty lines between multiline sibling blocks of HTML
To add some "air" and simplify reading. But don't add them between parent and child elements.