add task solution #5500
add task solution #5500
Conversation
Ivanna-Fedor
commented
Mar 14, 2025
Ivanna-Fedor
commented
- DEMO LINK](https://Ivanna-Fedor.github.io/layout_stars/)
- TEST REPORT LINK
There was a problem hiding this comment.
Hi! 👋 The code generally looks good and implements the stars block as required. The HTML structure seems correct, and the CSS styles are well-applied. However, there's one outstanding issue from the checklist: you need to add empty lines between multiline sibling blocks in your HTML. Please address this, and it'll be good to go! ✨
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
🤖 If you have any comments about this review, please leave a message in the Add a comment field below and mention me with @mateacademy-ai-mentor tag. I will read your message when I perform the next review of your pull request.
src/index.html
Outdated
| <div class="stars stars--0"> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| </div> |
There was a problem hiding this comment.
There should be an empty line between multiline sibling blocks of HTML.
See the checklist item:
Add empty lines between multiline sibling blocks of HTML
src/index.html
Outdated
| <div class="stars stars--1"> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| </div> |
There was a problem hiding this comment.
There should be an empty line between multiline sibling blocks of HTML.
See the checklist item:
Add empty lines between multiline sibling blocks of HTML
src/index.html
Outdated
| <div class="stars stars--2"> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| </div> |
There was a problem hiding this comment.
There should be an empty line between multiline sibling blocks of HTML.
See the checklist item:
Add empty lines between multiline sibling blocks of HTML
src/index.html
Outdated
| <div class="stars stars--3"> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star"></span> | ||
| <span class="star"></span> | ||
| </div> |
There was a problem hiding this comment.
There should be an empty line between multiline sibling blocks of HTML.
See the checklist item:
Add empty lines between multiline sibling blocks of HTML
src/index.html
Outdated
| <div class="stars stars--4"> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star stars__star--active"></span> | ||
| <span class="star"></span> | ||
| </div> |
There was a problem hiding this comment.
There should be an empty line between multiline sibling blocks of HTML.
See the checklist item:
Add empty lines between multiline sibling blocks of HTML
There was a problem hiding this comment.
The code is well-structured and adheres to the task requirements. The HTML now includes empty lines between the multiline div elements, improving readability. The CSS code is also well-structured. I noticed that in src/index.html, you have not added empty lines between multiline sibling blocks of HTML. Please add them to improve readability.
I've approved the PR to help you move forward, but please address the comments to improve your code. Great job and keep learning! ✨
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
