Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5501

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Robert-Mans
Copy link

  • DEMO LINK
  • TEST REPORT LINK
  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 The HTML structure is good, but the CSS needs some adjustments. You're using tag names (div) for styling, but the task requires using container modifiers and pseudo-selectors for the yellow stars instead of adding extra classes or using tag names. Also, each BEM block should have its own separate file according to the task description. Finally, please add empty lines between multi-line sibling blocks of HTML to improve readability. Keep up the good work! ✨

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

🤖 If you have any comments about this review, please leave a message in the Add a comment field below and mention me with @mateacademy-ai-mentor tag. I will read your message when I perform the next review of your pull request.

src/index.html Outdated
Comment on lines 16 to 22
<div class="stars stars--0">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".

src/index.html Outdated
Comment on lines 23 to 29
<div class="stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".

src/index.html Outdated
Comment on lines 30 to 36
<div class="stars stars--2">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".

src/index.html Outdated
Comment on lines 37 to 43
<div class="stars stars--3">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".

src/index.html Outdated
Comment on lines 44 to 50
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".

src/index.html Outdated
Comment on lines 51 to 57
<div class="stars stars--5">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".

src/style.css Outdated
Comment on lines 22 to 26
.stars--5 div,
.stars--1 div:nth-child(1),
.stars--2 div:nth-child(-n + 2),
.stars--3 div:nth-child(-n + 3),
.stars--4 div:nth-child(-n + 4) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This styling uses tag names (div), which is not recommended. According to the task description, "Yellow stars are added with container modifier + pseudo-selector (NO extra classes)". Consider using a pseudo-selector to target the stars__star elements directly based on the parent's modifier class. Also, the task description says: "Each BEM block has its own separate file".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is BEM?

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job completing the task! ✨ While the HTML structure is well-formatted and follows the instructions, there are a few things to keep in mind for future improvements:

  • CSS Adjustments: You're using tag names (div) for styling, but the task requires using container modifiers and pseudo-selectors for the yellow stars instead of adding extra classes or using tag names. Also, each BEM block should have its own separate file according to the task description.
  • File Structure: Remember that the task requires each BEM block to be in its own separate file. Currently, all CSS code is in a single style.css file.
  • Selectors: Avoid using tag names (.stars--5 div, .stars--1 div:nth-child(1)) for styling. Instead, use container modifiers and pseudo-selectors as required by the task.
  • HTML Formatting: Ensure there are empty lines between multi-line sibling blocks of HTML in src/index.html.

These points were considered when making the decision. Keep up the great work, and keep learning! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +6 to +8
body {
margin: 0;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the task requirements, you should reset the browser's default margin. Looks like you've done that, so this is correct.

src/style.css Outdated
Comment on lines 22 to 27
.stars--5 div,
.stars--1 div:nth-child(1),
.stars--2 div:nth-child(-n + 2),
.stars--3 div:nth-child(-n + 3),
.stars--4 div:nth-child(-n + 4) {
background-image: url('images/star-active.svg');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using tag names (div) for styling, but the task requires using container modifiers and pseudo-selectors for the yellow stars instead of adding extra classes or using tag names. Please, check the checklist item:

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants