-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5501
base: master
Are you sure you want to change the base?
add task solution #5501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! 👋 The HTML structure is good, but the CSS needs some adjustments. You're using tag names (div
) for styling, but the task requires using container modifiers and pseudo-selectors for the yellow stars instead of adding extra classes or using tag names. Also, each BEM block should have its own separate file according to the task description. Finally, please add empty lines between multi-line sibling blocks of HTML to improve readability. Keep up the good work! ✨
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
🤖 If you have any comments about this review, please leave a message in the Add a comment field below and mention me with @mateacademy-ai-mentor
tag. I will read your message when I perform the next review of your pull request.
src/index.html
Outdated
<div class="stars stars--0"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".
src/index.html
Outdated
<div class="stars stars--1"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".
src/index.html
Outdated
<div class="stars stars--2"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".
src/index.html
Outdated
<div class="stars stars--3"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".
src/index.html
Outdated
<div class="stars stars--4"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".
src/index.html
Outdated
<div class="stars stars--5"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an empty line between multi-line sibling blocks of HTML to improve readability, as described in the checklist under "HTML Formatting".
src/style.css
Outdated
.stars--5 div, | ||
.stars--1 div:nth-child(1), | ||
.stars--2 div:nth-child(-n + 2), | ||
.stars--3 div:nth-child(-n + 3), | ||
.stars--4 div:nth-child(-n + 4) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This styling uses tag names (div
), which is not recommended. According to the task description, "Yellow stars are added with container modifier + pseudo-selector (NO extra classes)". Consider using a pseudo-selector to target the stars__star
elements directly based on the parent's modifier class. Also, the task description says: "Each BEM block has its own separate file".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is BEM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job completing the task! ✨ While the HTML structure is well-formatted and follows the instructions, there are a few things to keep in mind for future improvements:
- CSS Adjustments: You're using tag names (
div
) for styling, but the task requires using container modifiers and pseudo-selectors for the yellow stars instead of adding extra classes or using tag names. Also, each BEM block should have its own separate file according to the task description. - File Structure: Remember that the task requires each BEM block to be in its own separate file. Currently, all CSS code is in a single
style.css
file. - Selectors: Avoid using tag names (
.stars--5 div
,.stars--1 div:nth-child(1)
) for styling. Instead, use container modifiers and pseudo-selectors as required by the task. - HTML Formatting: Ensure there are empty lines between multi-line sibling blocks of HTML in
src/index.html
.
These points were considered when making the decision. Keep up the great work, and keep learning! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
body { | ||
margin: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the task requirements, you should reset the browser's default margin. Looks like you've done that, so this is correct.
src/style.css
Outdated
.stars--5 div, | ||
.stars--1 div:nth-child(1), | ||
.stars--2 div:nth-child(-n + 2), | ||
.stars--3 div:nth-child(-n + 3), | ||
.stars--4 div:nth-child(-n + 4) { | ||
background-image: url('images/star-active.svg'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're using tag names (div
) for styling, but the task requires using container modifiers and pseudo-selectors for the yellow stars instead of adding extra classes or using tag names. Please, check the checklist item:
- Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Typical Mistakes
fromBEM
lesson theory are checked.