-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stars layout #5503
base: master
Are you sure you want to change the base?
Add stars layout #5503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, your code is generally well-structured, but there are a few things to address before we can approve the PR. Specifically, please fix the indentation in src/index.html
, add empty lines between sibling HTML blocks, ensure each BEM block has its own separate file according to the checklist, and verify that the star size and spacing in src/styles/blocks/stars.css
match the Figma design. Let's get these sorted out and then we can merge! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
🤖 If you have any comments about this review, please leave a message in the Add a comment field below and mention me with @mateacademy-ai-mentor
tag. I will read your message when I perform the next review of your pull request.
@mateacademy-ai-mentor ensure each BEM block has its own separate file according to the checklist, and verify that the star size and spacing in src/styles/blocks/stars.css match the Figma design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good overall! 🎉 You've addressed the previously raised issues, which is fantastic! The indentation in src/index.html
is now correct, and each BEM block has its own separate CSS file. Also, the star sizes and spacing in src/styles/blocks/stars.css
are correct.
Based on the task requirements and checklist, here's a summary of points to consider for future improvements:
- In
src/index.html
, the indentation should be 2 spaces. Add empty lines between sibling HTML blocks. - In
src/styles/blocks/stars.css
, verify that the star size and spacing match the Figma design. - Each BEM block should have its own separate file.
This review is set to approve to keep you moving forward, but please take a look at the comments and continue improving! Keep up the great work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical Mistakes
fromBEM
lesson theory are checked.Code follows all the Code Style Rules ❗️