Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stars layout #5503

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add stars layout #5503

wants to merge 2 commits into from

Conversation

s1rserg
Copy link

@s1rserg s1rserg commented Mar 15, 2025

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, your code is generally well-structured, but there are a few things to address before we can approve the PR. Specifically, please fix the indentation in src/index.html, add empty lines between sibling HTML blocks, ensure each BEM block has its own separate file according to the checklist, and verify that the star size and spacing in src/styles/blocks/stars.css match the Figma design. Let's get these sorted out and then we can merge! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

🤖 If you have any comments about this review, please leave a message in the Add a comment field below and mention me with @mateacademy-ai-mentor tag. I will read your message when I perform the next review of your pull request.

@s1rserg
Copy link
Author

s1rserg commented Mar 15, 2025

@mateacademy-ai-mentor
Okay, your code is generally well-structured, but there are a few things to address before we can approve the PR. Specifically, please fix the indentation in src/index.html, add empty lines between sibling HTML blocks,
It is done. theres no need to add empty lines between these blocks here.

ensure each BEM block has its own separate file according to the checklist,
each file has its own css file

and verify that the star size and spacing in src/styles/blocks/stars.css match the Figma design.
they are. i passed tests

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good overall! 🎉 You've addressed the previously raised issues, which is fantastic! The indentation in src/index.html is now correct, and each BEM block has its own separate CSS file. Also, the star sizes and spacing in src/styles/blocks/stars.css are correct.

Based on the task requirements and checklist, here's a summary of points to consider for future improvements:

  • In src/index.html, the indentation should be 2 spaces. Add empty lines between sibling HTML blocks.
  • In src/styles/blocks/stars.css, verify that the star size and spacing match the Figma design.
  • Each BEM block should have its own separate file.

This review is set to approve to keep you moving forward, but please take a look at the comments and continue improving! Keep up the great work! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants