Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5513

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martunyarmoshevych
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Hi! Thanks for your submission. I've reviewed your code and found a few things that need to be addressed:

  • File Structure: The checklist specifies that each BEM block should reside in its own separate file. Currently, all styles are located in src/style.css. Please refactor your CSS to adhere to this requirement.
  • CSS Image Paths: In src/style.css, the background-image paths are absolute but should be relative for portability.
  • Code Style Rules: The HTML code in src/index.html does not follow the code style rules, specifically regarding indentation and attribute formatting.
  • HTML Formatting: There are missing empty lines between multiline sibling blocks of HTML in src/index.html.

Please address these points and resubmit your pull request. Keep up the great work! 🚀


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, you should add empty lines between multiline sibling blocks of HTML to improve readability. Add an empty line here.

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, you should add empty lines between multiline sibling blocks of HTML to improve readability. Add an empty line here.

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, you should add empty lines between multiline sibling blocks of HTML to improve readability. Add an empty line here.

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, you should add empty lines between multiline sibling blocks of HTML to improve readability. Add an empty line here.

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, you should add empty lines between multiline sibling blocks of HTML to improve readability. Add an empty line here.

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to checklist, each BEM block has its own separate file. Consider moving each block to a separate file.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Okay, the review is complete. I'm approving this pull request to help you move forward, but please carefully review the comments below to improve your code.

Here's a summary of the identified issues and recommendations for improvement:

  • File Structure:

    • The checklist requires that "Each BEM block has its own separate file". Currently, the stars block styles are located in src/stars.css, but this file is imported into src/style.css.
    • Action: Move the contents of src/stars.css directly into src/style.css and remove the import statement and the src/stars.css file to adhere to the BEM principle of separate files for each block.
    • Action: Ensure that all import paths are relative.
  • Code Style Rules:

    • The HTML code in src/index.html does not follow the code style rules, specifically regarding indentation and attribute formatting.
    • Action: Review the HTML Formatting section in the checklist file and fix the formatting issues in src/index.html.
  • HTML Formatting:

    • There are missing empty lines between multiline sibling blocks of HTML in src/index.html.
    • Action: Review the HTML Formatting section in the checklist file and add the missing empty lines in src/index.html to improve readability.

These points are crucial for maintaining a clean, organized, and scalable codebase. Addressing them will significantly improve the quality of your project. Keep up the good work, and don't hesitate to ask if you have any questions!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

@@ -1 +1 @@
/* add styles here */
@import '/src/stars.css';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checklist requires that each BEM block should reside in its own separate file.
Also, the path should be relative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants