Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added task solution #5517

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added task solution #5517

wants to merge 2 commits into from

Conversation

cmac2617
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Hey there! 👋 Thanks for your submission! There are a couple of things to adjust: The styling for .stars--5 could be more consistent with other modifiers by using :nth-child. Also, remember to create separate files for each BEM block and keep your CSS lines under 80 characters. Keep up the great work! ✨


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

src/style.css Outdated
Comment on lines 61 to 67
.stars--5 > .stars__star {
background-image: url('./images/star-active.svg');
background-repeat: no-repeat;
background-position: center;
height: 16px;
width: 16px;
margin-right: 4px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the other modifiers, consider using :nth-child here as well. This will ensure a uniform approach for applying the active state to the stars. For example: .stars--5 > :nth-child(-n + 5).

Also, according to the task description:

Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Okay, great job completing the task! 🎉 I'm approving this pull request so you can move forward.

Here's a summary of the feedback to help you improve:

  • CSS File Structure: Remember to split your CSS code into separate files for each BEM block. This makes your code more organized and easier to maintain. For example, the .stars block, .stars__star element, and any modifiers (like .stars--large) should each have their own CSS file (e.g., stars.css, stars__star.css, stars--large.css). This adheres to the BEM principle of modularity.

  • Line Length: In src/style.css, try to keep lines of code to a maximum of 80 characters for better readability. You can break long lines into multiple shorter lines to stay within this limit.

Keep up the great work! 💪 By addressing these points in future pull requests, you'll be writing even cleaner and more maintainable code. Feel free to ask if you have any questions!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +6 to +14
.stars {
margin: 0;
padding: 0;
display: flex;

/* justify-content: space-between; */

/* width: 96px; */
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, "Each BEM block has its own separate file". Consider creating a separate file for the .stars block.

Comment on lines +16 to +23
.stars__star {
background-image: url('./images/star.svg');
background-repeat: no-repeat;
background-position: center;
height: 16px;
width: 16px;
margin-right: 4px;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, "Each BEM block has its own separate file". Consider creating a separate file for the .stars__star block.

Comment on lines +25 to +68
.stars--1 > :nth-child(-n + 1) {
background-image: url('./images/star-active.svg');
background-repeat: no-repeat;
background-position: center;
height: 16px;
width: 16px;
margin-right: 4px;
}

.stars--2 > :nth-child(-n + 2) {
background-image: url('./images/star-active.svg');
background-repeat: no-repeat;
background-position: center;
height: 16px;
width: 16px;
margin-right: 4px;
}

.stars--3 > :nth-child(-n + 3) {
background-image: url('./images/star-active.svg');
background-repeat: no-repeat;
background-position: center;
height: 16px;
width: 16px;
margin-right: 4px;
}

.stars--4 > :nth-child(-n + 4) {
background-image: url('./images/star-active.svg');
background-repeat: no-repeat;
background-position: center;
height: 16px;
width: 16px;
margin-right: 4px;
}

.stars--5 > :nth-child(-n + 5) {
background-image: url('./images/star-active.svg');
background-repeat: no-repeat;
background-position: center;
height: 16px;
width: 16px;
margin-right: 4px;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, "Each BEM block has its own separate file". Consider creating a separate file for the stars block modifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants