-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented layout stars #5527
base: master
Are you sure you want to change the base?
implemented layout stars #5527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Hey there! 👋 Thanks for your submission. There are a couple of things we need to address before approving this PR:
- HTML Formatting: The HTML in
src/index.html
isn't quite following our formatting guidelines. Specifically, when an HTML element has long attribute values or more than two attributes, each attribute should be on a new line, indented two spaces relative to the tag. - CSS Styling: In
src/styles/blocks/star.css
, you're using tag names for styling. It's better to stick to classes, pseudo-classes, pseudo-elements, and attributes for styling (except forhtml
andbody
). Could you update the.stars__star
rule to avoid using tag names?
Addressing these points will improve the readability and maintainability of your code. Keep up the great work! 👍
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review
button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor
tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job on this Pull Request! 🎉 All files have been reviewed and generally look good.
Here's a summary of the review, incorporating the details from the individual file reviews and the final conclusion:
-
src/index.html
: The HTML code is formatted correctly with attributes on new lines and proper indentation. -
src/styles/blocks/page.css
: The CSS implementation in this file meets the requirements. -
src/styles/blocks/star.css
: Excellent work on refactoring the styling to avoid tag names and utilize classes, pseudo-classes, pseudo-elements, and attributes correctly! -
src/styles/style.css
: The CSS implementation in this file meets the requirements.
Overall, the code is well-structured and adheres to the guidelines. You're on the right track! The decision to approve is made to allow you to move forward and continue your learning process. I encourage you to carefully review these points and apply them in your future work. Keep up the excellent work and continue honing your skills! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical Mistakes
fromBEM
lesson theory are checked.Code follows all the Code Style Rules ❗️