Skip to content

JDFTXOutfileSlice Durability Improvement #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

benrich37
Copy link
Contributor

Summary

Major changes:

  • feature 1: Improved durability of JDFTXOutfileSlice._from_out_slice method (less likely to error out on unexpected termination)
    -- So long as one step of electronic minimization has started on an out file slice, parsing shouldn't error out
  • fix 1: Allow partially dumped eigstats
  • fix 2: Added missing optical band gap dumped by eigstats
  • fix 3: Protect the final JOutStructure in initializing a JOutStructures with a try/except block
  • fix 4: Detect if positions were only partially dumped and revert to data from init_structure in JOutStructure
  • fix 5: Prevent partially dumped matrices from being used in initializing a JOutStructure

Todos

  • feature 1: Ensure parse-ability as long as a JDFTXOutfileSlice.infile can be initialized

@benrich37 benrich37 requested review from shyuep and mkhorton as code owners May 24, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant