Replace assert to check int in get_el_sp
#4527
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
get_el_spusesassertto check if obj is integar, this could be bypassed by the optimization flag (-O) and results in surprising behaviour, for example:However with
-Oit bypasses assert and gives Be because ofint(flt):python3 -O -c "from pymatgen.core.periodic_table import get_el_sp; print(get_el_sp(4.5))" >>> Be