Skip to content

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented May 8, 2025

Motivation for this change

fyi @mkerjean (application of Baire)

@IshiguroYoshihiro

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@t6s
Copy link
Member

t6s commented May 12, 2025

Why not parallelly formalize Fsigma sets too?
(renaming the file to borel_hierarchy.v)

@t6s
Copy link
Member

t6s commented May 13, 2025

like this affeldt-aist#40

@affeldt-aist
Copy link
Member Author

affeldt-aist commented May 13, 2025

Why not parallelly formalize Fsigma sets too? (renaming the file to borel_hierarchy.v)

Why not. We were just trying to keep the PR to a minimal to ease review.
A borel_hierarchy.v file sounds nice.

@affeldt-aist affeldt-aist marked this pull request as ready for review May 13, 2025 09:12
@affeldt-aist affeldt-aist requested a review from mkerjean May 13, 2025 09:12
@affeldt-aist
Copy link
Member Author

The last commit moves the definition rational that was lingering into pi_irrational.v into reals.v along with the definition of irrational. It is a bit more principled but a bit longish. There are lemmas about dense in borel_hierarchy.v that should maybe be moved near the definition of dense. The file borel_hierarchy.v is a bit short. Do you have something in mind @t6s ?

By the way, @IshiguroYoshihiro and I wanted to introduce these definitions because they are use in work in progress and since we proved a lemma using Baire and rational that were already in master, we thought it was timely.

@t6s
Copy link
Member

t6s commented May 13, 2025

It looks short but a nice place for future additions, e.g., a generic definition of the borel hierarchy parametrized by a well-ordered set.

Btw, there will be another demand for this PR from PR #1585 (by @motikaku), where perfect normality is introduced in terms of (sharp) Urysohn functions, but is planned to be related to Gdelta sets (Vedenissoff's theorem).

Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Co-authored-by: IshiguroYoshihiro <[email protected]>
Co-authored-by: Takafumi Saikawa <[email protected]>
@affeldt-aist
Copy link
Member Author

I'll merge tomorrow if the CI is green unless there is new input.

@affeldt-aist affeldt-aist merged commit 3402d90 into math-comp:master Jul 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants