Skip to content

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Aug 27, 2025

This enables incorporating the lra/nra/psatz tactics in algebra without requiring Stdlib.
It also retrieves the ring and field tactics from algebra-tactics, adapting them so that they work without Stdlib dependency.

TODO

  • ring tactic handling hypotheses
  • field tactic
  • added changelog entries with doc/changelog/make-entry.sh
  • added corresponding documentation in the headers
  • tried to abide by the contribution guide
  • this PR contains an optimum number of meaningful commits

Future work

  • improve Elpi derive.param2 to simplify the refinement part of lra.v or rather use Trocq
  • could it be made to work for numDomainType and numFieldType rather than just realDomainType and realFieldType?
  • lia tactic

Overlays (to be merged before the current PR)

Successfully tested on

See this Checklist for details.

Automatic note to reviewers

Read this Checklist.

@proux01 proux01 added this to the 2.5.0 milestone Aug 27, 2025
@proux01 proux01 added the needs: merge of dependencies PR that depends on another. Documented in the original post of the PR. Review only the increment. label Aug 27, 2025
@proux01 proux01 mentioned this pull request Aug 27, 2025
9 tasks
@proux01 proux01 force-pushed the ring branch 5 times, most recently from 45ca9b7 to 2811750 Compare September 3, 2025 05:41
proux01 added a commit to proux01/algebra-tactics that referenced this pull request Sep 3, 2025
proux01 added a commit to rocq-community/bits that referenced this pull request Sep 4, 2025
proux01 added a commit to proux01/apery that referenced this pull request Sep 4, 2025
proux01 added a commit to rocq-community/graph-theory that referenced this pull request Sep 4, 2025
@proux01 proux01 force-pushed the ring branch 2 times, most recently from 80b7a92 to 581d0ce Compare September 4, 2025 14:38
proux01 added a commit to proux01/apery that referenced this pull request Sep 4, 2025
proux01 added a commit to rocq-community/bits that referenced this pull request Sep 4, 2025
proux01 added a commit to rocq-community/graph-theory that referenced this pull request Sep 4, 2025
@proux01 proux01 force-pushed the ring branch 3 times, most recently from 109e5d1 to 309cbaa Compare September 5, 2025 06:51
proux01 added a commit to proux01/infotheo that referenced this pull request Sep 5, 2025
proux01 added a commit to proux01/infotheo that referenced this pull request Sep 5, 2025
@proux01 proux01 force-pushed the ring branch 3 times, most recently from 485495b to dc12695 Compare September 5, 2025 15:43
proux01 added a commit to proux01/infotheo that referenced this pull request Sep 6, 2025
affeldt-aist pushed a commit to affeldt-aist/monae that referenced this pull request Sep 18, 2025
proux01 added a commit to proux01/infotheo that referenced this pull request Sep 19, 2025
affeldt-aist pushed a commit to affeldt-aist/infotheo that referenced this pull request Sep 22, 2025
@proux01
Copy link
Contributor Author

proux01 commented Sep 23, 2025

So, to sum up, this has been successfully tested with everything identified during the last call (precise list in the top message)

@pi8027
Copy link
Member

pi8027 commented Oct 1, 2025

To be clear, I will neither further review this PR nor maintain this code. I suggest finding another reviewer who can potentially co-maintain the code.

@proux01
Copy link
Contributor Author

proux01 commented Oct 2, 2025

The Docker CI failure has already been reported: https://gitlab.inria.fr/fpottier/menhir/-/issues/81

@proux01 proux01 modified the milestones: 2.5.0, 2.6.0 Oct 13, 2025
@proux01
Copy link
Contributor Author

proux01 commented Oct 13, 2025

Postponing to 2.6.0

@proux01 proux01 removed the needs: merge of dependencies PR that depends on another. Documented in the original post of the PR. Review only the increment. label Oct 17, 2025
@proux01 proux01 changed the title ring without Stdlib lra/nra/psatz/ring/field without Stdlib Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants