-
Notifications
You must be signed in to change notification settings - Fork 124
lra/nra/psatz/ring/field without Stdlib #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
proux01
wants to merge
14
commits into
math-comp:master
Choose a base branch
from
proux01:ring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+6,686
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45ca9b7
to
2811750
Compare
proux01
added a commit
to proux01/algebra-tactics
that referenced
this pull request
Sep 3, 2025
proux01
added a commit
to rocq-community/bits
that referenced
this pull request
Sep 4, 2025
proux01
added a commit
to proux01/apery
that referenced
this pull request
Sep 4, 2025
proux01
added a commit
to rocq-community/graph-theory
that referenced
this pull request
Sep 4, 2025
80b7a92
to
581d0ce
Compare
proux01
added a commit
to proux01/apery
that referenced
this pull request
Sep 4, 2025
proux01
added a commit
to rocq-community/bits
that referenced
this pull request
Sep 4, 2025
proux01
added a commit
to rocq-community/graph-theory
that referenced
this pull request
Sep 4, 2025
109e5d1
to
309cbaa
Compare
proux01
added a commit
to proux01/infotheo
that referenced
this pull request
Sep 5, 2025
proux01
added a commit
to proux01/infotheo
that referenced
this pull request
Sep 5, 2025
485495b
to
dc12695
Compare
proux01
added a commit
to proux01/infotheo
that referenced
this pull request
Sep 6, 2025
affeldt-aist
pushed a commit
to affeldt-aist/monae
that referenced
this pull request
Sep 18, 2025
proux01
added a commit
to proux01/infotheo
that referenced
this pull request
Sep 19, 2025
affeldt-aist
pushed a commit
to affeldt-aist/infotheo
that referenced
this pull request
Sep 22, 2025
So, to sum up, this has been successfully tested with everything identified during the last call (precise list in the top message) |
To be clear, I will neither further review this PR nor maintain this code. I suggest finding another reviewer who can potentially co-maintain the code. |
The Docker CI failure has already been reported: https://gitlab.inria.fr/fpottier/menhir/-/issues/81 |
Postponing to 2.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables incorporating the lra/nra/psatz tactics in algebra without requiring Stdlib.
It also retrieves the ring and field tactics from algebra-tactics, adapting them so that they work without Stdlib dependency.
TODO
doc/changelog/make-entry.sh
Future work
Overlays (to be merged before the current PR)
Successfully tested on
See this Checklist for details.
Automatic note to reviewers
Read this Checklist.