Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Sep 10, 2025

This PR update the CSS used for the visual help icon when the explorer is running so that it:

  • doesn't get clipped when used with overflow="scroll" or overflow="truncate".
  • floats at the right during scrolling for overflow="scroll" and isn't truncated for overflow="truncate"
  • puts the icon next to a displayed expression when there isn't an equation tag (rather than at the far right as currently).

Resolves issue mathjax/MathJax#3432.

@dpvc dpvc requested a review from zorkow September 10, 2025 17:39
@dpvc dpvc added this to the v4.0.1 milestone Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.71%. Comparing base (afaf1ea) to head (654924f).
⚠️ Report is 67 commits behind head on develop.

Files with missing lines Patch % Lines
ts/output/common.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1350      +/-   ##
===========================================
- Coverage    86.72%   86.71%   -0.01%     
===========================================
  Files          337      337              
  Lines        84145    84146       +1     
  Branches      3140     4769    +1629     
===========================================
  Hits         72971    72971              
+ Misses       11174    11152      -22     
- Partials         0       23      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zorkow
Copy link
Member

zorkow commented Oct 10, 2025

  • puts the icon next to a displayed expression when there isn't an equation tag (rather than at the far right as currently).

I find this too close to the expression; see below. Can we somehow have it on the edge of the top-level highlighter box?

image

@dpvc
Copy link
Member Author

dpvc commented Oct 10, 2025

This is the same positioning use for inline expressions. The overlap is intentional to help link the info icon to the expression itself. I suppose it could be moved to the right for display expressions, but right now it is consistent with the inline placement.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 01b8b8e into develop Oct 17, 2025
2 of 3 checks passed
@dpvc dpvc deleted the issue3432 branch October 17, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants