Skip to content

Fix deployment permissions #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 6 commits into from
Oct 22, 2025
Merged

Fix deployment permissions #206

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac01bc9
Fix deployment permissions
story645 Oct 6, 2025
42034d3
changed wording
story645 Oct 6, 2025
e3928ee
comma
story645 Oct 6, 2025
cb5b588
put permissions under jobs
story645 Oct 9, 2025
3756b80
change intro wording
story645 Oct 9, 2025
3a2f7cc
Update docs/source/intro.rst
story645 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gh-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: GitHub Pages
permissions:
contents: read

contents: write
deployments: write
Copy link
Member

@timhoffm timhoffm Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how relevant this is because we have only one job, but the general recommendation is

  • Set top-level permissions as read-all or contents: read as described in GitHub's documentation.
  • Set any required write permissions at the job-level. Only set the permissions required for that job; do not set permissions: write-all at the job level.

on:
push:
branches:
Expand Down
4 changes: 2 additions & 2 deletions docs/source/intro.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
A list of packages that extend Matplotlib. These are maintained
and distributed independently from Matplotlib so go to the website
listed for instructions.
and distributed independently from Matplotlib, so go to each listed
website for instructions.

Please contribute your package by opening a pull-request at
https://github.com/matplotlib/mpl-third-party using the template in the
Expand Down