Skip to content

Dashboard: Fallback for unknown endpoint device types #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Apollon77 merged 2 commits into from
Dec 12, 2025
Merged

Dashboard: Fallback for unknown endpoint device types #1303

Apollon77 merged 2 commits into from
Dec 12, 2025

Conversation

@lboue
Copy link
Contributor

@lboue lboue commented Dec 11, 2025 •
edited
Loading

PR Summary

Title: Dashboard: Fallback for unknown endpoint device types

Description:
This PR fixes a bug where the Matter dashboard would display a blank page when an endpoint had an unknown device type.

Changes:

  • Modified getEndpointDeviceTypes() in dashboard/src/pages/matter-endpoint-view.ts
  • Added fallback handling: when a device type ID is not found in the device_types dictionary, it now returns a placeholder object with label "Unknown Device Type (ID)" instead of undefined
  • This ensures the dashboard renders gracefully and displays the numeric ID to help identify missing device type definitions

Test Results:

  • ✅ Lint checks passed
  • ✅ Tests passed (Python 3.12 & 3.13)

Tests

Before: Unknown device types caused the page to error/blank

After: Unknown device types display as "Unknown Device Type (123)" and render normally

image

lboue added 2 commits December 11, 2025 10:47
@lboue
Fallback for unknown endpoint device types so the dashboard renders i…
31cbea6 
…nstead of erroring and shows “Unknown Device Type” when no description is found
@lboue
Update label for unknown device types to include ID in getEndpointDev…
209c8f8 
…iceTypes
@lboue lboue changed the title Fallback for unknown endpoint device types Dashboard: Fallback for unknown endpoint device types Dec 11, 2025
@lboue
Copy link
Contributor Author

lboue commented Dec 11, 2025 •
edited
Loading

Could you add a PR label to fix the test?

@Apollon77 Apollon77 added bugfix Pull request that fixes a (known) issue/bug maintenance Code (quality) improvement or small enhancement which not a new feature frontend labels Dec 12, 2025
@Apollon77 Apollon77 merged commit 285ab50 into matter-js:main Dec 12, 2025
6 of 7 checks passed
@lboue lboue deleted the unknown_endpoint branch December 12, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apollon77 Apollon77 Apollon77 approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes a (known) issue/bug frontend maintenance Code (quality) improvement or small enhancement which not a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lboue @Apollon77