-
Notifications
You must be signed in to change notification settings - Fork 609
Update database connection pool defaults for MM-63726 #8259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v11.0-documentation
Are you sure you want to change the base?
Update database connection pool defaults for MM-63726 #8259
Conversation
- Update MaxOpenConns default from 300 to 100 - Update MaxIdleConns default from 20 to 50 - Move MaxIdleConns from deprecated to active configuration settings - Update high availability deployment example configuration - Remove deprecated MaxIdleConns section as it's no longer deprecated This implements the v11 breaking changes to adjust database connection pool settings to use a safer 2:1 ratio (MaxOpenConns:MaxIdleConns).
| This feature's ``config.json`` setting is ``"StreamingPort": ":8075"`` with string input. | | ||
+-------------------------------------------------------------------------------------------+ | ||
|
||
Maximum idle database connections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setting was incorrectly marked as deprecated in #7122.
Newest code from mattermost has been published to preview environment for Git SHA c759155 |
…abase-connection-defaults
@cwarnermm, I remember your teaching me about a branch for upcoming changes, but I regret I can't remember what to do here. Is there a v11 branch I should be using? |
Newest code from mattermost has been published to preview environment for Git SHA 91147f9 |
@lieut-data - Release management creates a new monthly release branch following each monthly release on the 16th. There's a |
Newest code from mattermost has been published to preview environment for Git SHA 92712a2 |
Newest code from mattermost has been published to preview environment for Git SHA 2d24c39 |
Newest code from mattermost has been published to preview environment for Git SHA fdf7dfa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I was looking at the preview and wondering how useful would it be to explain when to change these values (not only the ones in the PR). It may look a bit verbose but as it is, this doesn't look helpful IMHO.
Newest code from mattermost has been published to preview environment for Git SHA 0761e82 |
You're right, @isacikgoz -- an addition to https://docs.mattermost.com/administration-guide/scale/scaling-for-enterprise.html might be an excellent place to document how to effectively use these parameters, but I fear I don't currently know how to codify that knowledge. I think the defaults here inch us towards a better initial experience, but will still require expertise for the particular system being deployed. |
Newest code from mattermost has been published to preview environment for Git SHA 70df772 |
* Update SAML encryption documentation for AES-256-GCM support - Add clarification that AES-256-GCM encryption support was introduced in v10.9 and backported to v10.6.5 - Include backwards compatibility messaging that existing SAML integrations continue working without changes - Note that only customers wanting to use AES-256-GCM keys need to update their configuration - Update main SAML SSO documentation to reference new encryption support - Update technical documentation to include version information Resolves #8349 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Carrie Warner (Mattermost) <[email protected]> * Update source/administration-guide/onboard/sso-saml-technical.rst Co-authored-by: Ben Schumacher <[email protected]> * Update source/administration-guide/onboard/sso-saml.rst Co-authored-by: Ben Schumacher <[email protected]> * Update source/deployment-guide/encryption-options.rst * Update source/deployment-guide/encryption-options.rst * Minor updates based on reviewer feedback --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Carrie Warner (Mattermost) <[email protected]> Co-authored-by: Ben Schumacher <[email protected]>
* Add references to Azure Local * Editorial review updates --------- Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
* docs: Update v10.5.11 dot release documentation - Added v10.5.11 changelog entry with security fixes notice - Updated server releases table to reference v10.5.11 downloads and SBOMs - Updated version archive for both Enterprise and Team editions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Amy Blais <[email protected]> * Update mattermost-v10-changelog.md * Update version-archive.rst --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Amy Blais <[email protected]> Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
* Update docs for Desktop v5.13.1 release - Updated download links and version references from v5.13.0 to v5.13.1 - Added v5.13.1 changelog entry as patch release - Updated installation instructions for all platforms 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Amy Blais <[email protected]> * Update desktop-app-changelog.md * Update desktop-msi-installer-and-group-policy-install.rst * Update desktop-msi-installer-and-group-policy-install.rst * Update desktop-app-changelog.md * Update desktop-app-changelog.md * Update desktop-app-changelog.md --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Amy Blais <[email protected]>
* Update deprecated-features.rst * Update deprecated-features.rst * Update deprecated-features.rst * Update deprecated-features.rst * Update source/product-overview/deprecated-features.rst * Update source/product-overview/deprecated-features.rst Co-authored-by: Alejandro García Montoro <[email protected]> --------- Co-authored-by: Carrie Warner (Mattermost) <[email protected]> Co-authored-by: Alejandro García Montoro <[email protected]>
* Environmental config setting consistency & normalization script * Fixed malformed tables * Config consistency & malformed table fixes * Removed helper script
* Update faq-business.rst Review and refinement * Update source/product-overview/faq-business.rst * Update faq-license.rst Removed redundant information, linking to single source * Update faq-business.rst * Update faq-business.rst * Update faq-license.rst Combined Business & Licensing since the pages covered redundant questions. * Delete source/product-overview/faq-business.rst Moved content to License FAQ & renamed * Added page redirect & child page nav * Incorporated reviewer feedback * Update faq-general.rst * Delete source/product-overview/faq-illicit-use.rst * Cleaned up nav following content moves --------- Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
* Update v9.x releases to legacy status - Remove v9.x versions from active release table in mattermost-server-releases.md - Move v9 changelog content to unsupported-legacy-releases.md - Update release-policy.md to include v9.x in legacy releases table - Replace v9 changelog with redirect to unsupported legacy releases - Update references to point to legacy releases documentation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Amy Blais <[email protected]> * Update unsupported-legacy-releases.md * Update mattermost-server-releases.md * Update mattermost-v9-changelog.md * Update server.rst * Update common-esr-support-upgrade.md * Update unsupported-legacy-releases.md * Update prepare-to-upgrade-mattermost.rst * Update prepare-to-upgrade-mattermost.rst * Update prepare-to-upgrade-mattermost.rst * Update prepare-to-upgrade-mattermost.rst * Update prepare-to-upgrade-mattermost.rst * Update prepare-to-upgrade-mattermost.rst * Update common-esr-support-upgrade.md * Update common-esr-support-upgrade.md * Update release-policy.md * Update prepare-to-upgrade-mattermost.rst --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Amy Blais <[email protected]> Co-authored-by: Carrie Warner (Mattermost) <[email protected]> Co-authored-by: Sven Hüster <[email protected]>
* Update deprecated-features.rst * Update common-esr-support-upgrade.md * Update release-policy.md
* Moved client availability page to end user guide * Returned headings to tabbed content with toctree pages
Newest code from mattermost has been published to preview environment for Git SHA 3ec9942 |
Summary
Updates documentation to reflect the v11 breaking changes from MM-63726:
This also corrects #7122 which incorrectly marked the MaxIdleConns setting as deprecated.
Implementation: mattermost/mattermost#33593
Test plan