Skip to content

Conversation

@tomblanchard
Copy link

I am using liquid.js in a Node.js environment and am getting the document is not defined error when compiling templates due to strftime relying on the DOM, document doesn't exist in Node.js, my changes make is so strftime is used only when window is present (i.e. in a browser environment).

@mattmccray
Copy link
Owner

Does this still build correctly and pass all the tests?

@tomblanchard
Copy link
Author

@mattmccray Sure does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants