hide/show connect/disconnect instead of just disabling#5
Open
SoMuchForSubtlety wants to merge 1 commit into
Open
hide/show connect/disconnect instead of just disabling#5SoMuchForSubtlety wants to merge 1 commit into
SoMuchForSubtlety wants to merge 1 commit into
Conversation
Owner
|
Hmm, Those are always appears on Windows ver. |
Contributor
Author
looks like it's also like that for mac To me it makes more sense to only show the option you can actually use, but I guess it is better to be consistent with the other versions. |
Contributor
Author
|
Its also worth considering, that the connect and disconnect options take up less space on Windows and mac than on Linux (at least with gnome). |
Owner
|
Give me a while to decide which is easier to use. :) |
Contributor
Author
|
I just realized, if you're not connected windows also only shows one option 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.