Helpers cleanup #18
Open
Helpers cleanup #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of github.com:mattrmiller/laravel-potion: Update composer.json
- Updated leafo/scssphp dependency
…r asset helpers - Added missing "?" versioning output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where I incorrectly assumed the order of parameters between assetCss and the other asset helpers would be similar, but they weren't, so I moved the $rel argument to the end of the argument list so that $name and $version would be the first two arguments on all of the asset helpers. I recognize this would constitute a backwards-compatibility issue for those using Potion 1.x.
I also needed the ability to set the defer attribute on certain JS assets, so I added that optional argument to the assetJs helper.
The assetUrl method was not including a ? before the cache-busting v URL parameter, so I added that.
Lastly, and I know this is a style preference, I think the generated asset HTML tags would almost always be wanted on their own line, so I added a newline character to the HTML returned from each asset helper.