keep the message id intact if persistence fails (Chainlit#200)

* keep the message id intact if persistence fails

* fix test

* fix typo

cypress/e2e/client_factory/main.py

@@ -71,4 +71,6 @@ async def client_factory(user_infos):
 
 @cl.on_chat_start
 async def on_chat_start():
-    await cl.Message("Hello").send()
+    msg = cl.Message(content="Hello")
+    msg.fail_on_persist_error = True
+    await msg.send()

src/chainlit/emitter.py

@@ -74,9 +74,11 @@ async def process_user_message(self, message: Dict):
         if self.db_client:
             # We have to update the UI with the actual DB ID
             ui_message_update = message.copy()
-            message["id"] = await self.db_client.create_message(message)
-            ui_message_update["newId"] = message["id"]
-            await self.update_message(ui_message_update)
+            persisted_id = await self.db_client.create_message(message)
+            if persisted_id:
+                message["id"] = persisted_id
+                ui_message_update["newId"] = message["id"]
+                await self.update_message(ui_message_update)
 
         self.session.root_message = Message.from_dict(message)
 

src/chainlit/message.py

@@ -23,7 +23,7 @@ class MessageBase(ABC):
     id: str = None
     streaming = False
     created_at: int = None
-    fail_on_persist_error: bool = True
+    fail_on_persist_error: bool = False
     persisted = False
 
     def __post_init__(self) -> None:
@@ -42,9 +42,11 @@ async def _create(self):
         msg_dict = self.to_dict()
         if self.emitter.db_client and not self.persisted:
             try:
-                self.id = await self.emitter.db_client.create_message(msg_dict)
-                msg_dict["id"] = self.id
-                self.persisted = True
+                persisted_id = await self.emitter.db_client.create_message(msg_dict)
+                if persisted_id:
+                    msg_dict["id"] = persisted_id
+                    self.id = persisted_id
+                    self.persisted = True
             except Exception as e:
                 if self.fail_on_persist_error:
                     raise e