Skip to content

Check login flows only if MSC4190 is not enabled #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meson800
Copy link

Currently, the homeserver login flows are checked even if MSC4190 is enabled. However, the flows variable is unused when MSC4190 is enabled.

This is an unnecessary network call, and also e.g. requires a reverse proxy soley for this purpose if bridges would otherwise directly connect to a homeserver that is delegating OIDC authentication.

Closes #177.

Testing, linting, etc

  • This change didn't have the test suite run, since locally my CMake version differs, so the olm package build fails locally, etc.
  • I ran black and the pre-commit hooks from the Github actions.
  • This bridge was tested on my homeserver, using my custom build of mautrix-googlechat that uses mautrix-python from this commit with MSC4190 support. Docker container build here. Messages flow bidirectionally, double puppeting works, etc.

Currently, the homeserver login flows are checked even if MSC4190 is
enabled. However, the `flows` variable is unused when MSC4190 is
enabled.

This is an unnecessary network call, and also e.g. requires a
reverse proxy soley for this purpose if bridges would otherwise
directly connect to a homeserver that is delegating OIDC authentication.

Closes mautrix#177.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

MSC4190 login fails with MAS, due to unnecessarily checking for login flows
1 participant