Skip to content

Update active_record_doctor 1.9.0 → 1.15.0 (minor) #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented Aug 31, 2024


Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ active_record_doctor (1.9.0 → 1.15.0) · Repo · Changelog

Release Notes

1.15.0 (from changelog)

  • New feature: detector to find tables without a primary key (contributed by fatkodima).
  • Enhancement: extraneous_indexes takes into account the INCLUDE part of index definitions (contributed by fatkodima).
  • Enhancement: missing_presence_validation takes a new setting ignore_columns_with_default (contributed by fatkodima).
  • Enhancement: missing_unique_indexes supports HABTM associations (contributed by fatkodima).
  • Enhancement: missing_non_null_constraint support STI columns (contributed by fatkodima).
  • Enhancement: missing_non_null_contraint supports belongs_to_required_validates_foreign_key (contributed by fatkodima).
  • Enhancement: ignore_models can be passed class objects (contributed by fatkodima).
  • Bug fix: avoid false positives on missing case-insensitive uniqueness indexes when using Postgres citext strings (contributed by gee-forr).

1.14.0 (from changelog)

  • Enhancement: the default configuration file has the .rb suffix to help editors automatically recognize the content Ruby (contributed by Jon Dufresne).

1.13.0 (from changelog)

  • New feature: regexp-based ignore settings (contributed by fatkodima).
  • Bug fix: ignore_columns is correctly handed in missing_unique_indexes ( contributed by fatkodima).
  • Bug fix: primary keys are automatically recognized as indexed and unique by unindexed_foreign_keys and missing_unique_indexes (contributed by fatkodima).
  • Bug fix: a typo in the description of incorrect_boolean_presence_validation is fixed (contributed by Jon Dufresne).

1.12.0 (from changelog)

  • New feature: detect extraneous indexes on PostgreSQL materialized views (contributed by fatkodima).
  • New feature: support for case-insensitive validations in missing_unique_indexes (contributed by fatkodima).
  • New feature: support for has_one in missing_unique_indexes (contributed by fatkodima).
  • New feature: support for async options in incorrect_dependent_option (contributed by fatkodima).
  • Bug fix: make Rake integration work in non-Rails projects (contributed by fatkodima).
  • Bug fix: ignore inherited validations in missing_unique_indexes (contributed by fatkodima).
  • Bug fix: make extraneous_indexes work on expression indexes (contributed by fatkodima).
  • short_primary_key type checks only integer indexes as they are the ones at the risk of running out (contributed by fatkodima).
  • unindexed_foreign_keys looks at actual foreign keys, instead of guessing based on column name (contributed by fatkodima).
  • Improvements and clarifications to documentation and error messages (contributed by Kurtis Rainbolt-Greene, Vincent Glennon, and fatkodima).

1.11.0 (from changelog)

  • New feature: support for polymorphic associations in missing_non_null_constraint (contributed by fatkodima).
  • New feature: support for foreign tables in PostgreSQL (contributed by fatkodima).
  • New feature: debug logging for easier troubleshooting.
  • Bug fix: incorrect_length_validation used to take the first length validator on the model, even if it didn't correspond to the column under consideration. This is no longer the case (contributed by Julián Lires).
  • Bug fix: inclusion and exclusion validators can contain a proc in in: or within: which makes them impossible to analyze by active_record_doctor; such validations are now skipped (contributed by fatkodima).
  • Fixed to documentation for incorrect_dependent_option (contributed by Erick Santos).
  • Bug fix: mismatched_foreign_key_type used to always look at the type of the primary key in the other table, even if the foreign key was referencing a different column; the right column is now taken into account (contributed by Bruno Gerotto).
  • Bug fix: incorrect_dependent_option didn't work correctly on through: associations as it would look at the final model (instead of the join model); additionally, if the join model lacked the corresponding has_many association it would result in NoMethodError.

1.10.0 (from changelog)

  • New feature: incorrect_length_validation detector can identify text-column length mismatches between tables and models (suggested by fatkodima).
  • New feature: each detector can be enabled or disabled globally via the configuration file.
  • Enhancement: missing_non_null_constraints and missing_presence_validation recognized NOT NULL check constraints (contributed by fatkodima).
  • Enhancement: missing_unique_index is aware of has_one associations and recommends creating an index on the corresponding foreign key (contributed by fatkodima).
  • Bug fix: missing_unique_indexes can be satisfied by creating an index on a sublist of scope + column. Previously, it'd not accept such sublists even though they're enough to guarantee uniqueness (contributed by fatkodima).
  • Bug fix: fix missing_unique_indexes crashes on function indexes (contributed by fatkodima).
  • Bug fix: short_primary_key_type no longer complains about UUID primary keys (contributed by fatkodima).
  • Bug fix: extraneous_indexes was made aware of non-standard primary key names and partial indexes (contributed by fatkodima).
  • Bug fix: extraneous_indexes properly recognizes smaller indexes to be enough to guarantee uniqueness. Previously, it'd skip some smaller indexes and ask for a larger index to be created (contributed by fatkodima).
  • Bug fix: unindexed_deleted_at correctly works on partial indexes intended to cover deleted columns. It no longer asks to create a contradictory condition (IS NULL AND IS NOT NULL) in those cases (contributed by fatkodima).
  • Bug fix: incorrect_dependent_option works correctly on polymorphic associations.
  • Bug fix: recognize the PostGIS adapter as PostgreSQL (contributed by fatkodima).
  • Bug fix: index generators use index_name_length (defined by Active Record) to ensure index names aren't too long (contributed by fatkodima).
  • Tested against Ruby 3.1 via CI (contributed by Peter Goldstein).
  • Documentation fixes (contributed by Alistair McKinnell and Kaleb Lape).

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ concurrent-ruby (indirect, 1.1.10 → 1.3.4) · Repo · Changelog

Release Notes

1.3.4

What's Changed

  • Update comment for JRuby variant of processor_count to reality by @meineerde in #1054
  • Add Concurrent.cpu_requests that is cgroups aware. by @heka1024 in #1058
  • Fix the doc of Concurrent.available_processor_count by @y-yagi in #1059
  • Fix the return value of Concurrent.available_processor_count when cpu.cfs_quota_us is -1 by @y-yagi in #1060

New Contributors

Full Changelog: v1.3.3...v1.3.4

1.3.3

What's Changed

Full Changelog: v1.3.2...v1.3.3

1.3.2

What's Changed

New Contributors

Full Changelog: v1.3.1...v1.3.2

1.3.1

This release is essentially v1.3.0, but with a properly packaged gem. There was an issue publishing v1.3.0 and that gem needed to be yanked to avoid breaking downstream projects. The v1.3.0 changelog is reproduced below.

What's Changed

  • Add Concurrent.usable_processor_count that is cgroups aware by @casperisfine in #1038
  • Align Java Executor Service behavior for shuttingdown?, shutdown? by @bensheldon in #1042

New Contributors

Full Changelog: v1.2.3...v1.3.1

1.2.3

What's Changed

New Contributors

Full Changelog: v1.2.2...v1.2.3

1.2.2

concurrent-ruby 1.2.2:

  • (#993) Fix arguments passed to Concurrent::Map's default_proc.

1.2.1

concurrent-ruby 1.2.1:

  • (#990) Add missing require 'fiber' for FiberLocalVar.
  • (#989) Optimize Concurrent::Map#[] on CRuby by letting the backing Hash handle the default_proc.

1.2.0

concurrent-ruby 1.2.0:

  • (#975) Set the Ruby compatibility version at 2.3
  • (#962) Fix ReentrantReadWriteLock to use the same granularity for locals as for Mutex it uses.
  • (#983) Add FiberLocalVar
  • (#934) concurrent-ruby now supports requiring individual classes (public classes listed in the docs), e.g., require 'concurrent/map'
  • (#976) Let Promises.any_fulfilled_future take an Event
  • Improve documentation of various classes
  • (#972) Remove Rubinius-related code

concurrent-ruby-edge 0.7.0:

  • (#975) Set the Ruby compatibility version at 2.3
  • (#934) concurrent-ruby now supports requiring individual classes (public classes listed in the docs), e.g., require 'concurrent/map'
  • (#972) Remove Rubinius-related code

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ i18n (indirect, 1.12.0 → 1.14.5) · Repo · Changelog

Release Notes

1.14.5

What's Changed

  • Explicitly bundle racc gem for Ruby 3.3+ by @amatsuda in #690
  • Optimize I18n::Locale::Fallbacks#[] for recursive locale mappings by @uiur in #692
  • Add I18n.interpolation_keys by @tom-lord in #682
  • Fix syntax in documentation for I18n::Backend::Base.interpolate by @tom-lord in #691
  • Fix that escaped interpolations with reserved keywords raised ReservedInterpolationKey by @Bilka2 in #688

New Contributors

Full Changelog: v1.14.4...v1.14.5

1.14.4

What's Changed

Note: the racc dependency will be coming back in Version 2.

  • undo strict racc dependency on this branch by @radar in #687

Full Changelog: v1.14.3...v1.14.4

1.14.3

What's Changed

  • Pass options to along to exists? super calls by @radar in #671
  • Improve TOKENIZER by 23% by @kbrock in #668
  • Regex part deux - INTERPOLATION_SYNTAX by @kbrock in #669
  • Raise when translated entry contains interpolations for reserved keywords and no substitutions provided by @fatkodima in #678
  • Implement Fallbacks#inspect and Fallbacks#empty? by @fatkodima in #683

Upkeep

New Contributors

Full Changelog: v1.14.1...v1.14.3

1.14.1

Included in this release

  • Simplify the "Translation missing" message when default is an empty Array by @amatsuda in #662

Maintenance stuff

Thanks to @amatsuda for these PRs!

New Contributors

Full Changelog: v1.14.0...v1.14.1

1.14.0

What's Changed

  • fix LazyLoadable#available_locales duplicating locales by @ccutrer in #655
  • Add more helpful translation error when :default option is provided. by @Nerian in #654
  • Fix I18n::Locale::Fallbacks not initializing itself on Ruby 3 by @yheuhtozr in #653
  • Fix I18n.t when locale contains separator by @tubaxenor in #656
    • This reverts a change from #651, that was released in v1.13.0

New Contributors

Full Changelog: v1.13.0...v1.14.0

1.13.0

What's Changed

New Contributors

Full Changelog: v1.12.0...v1.13.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ minitest (indirect, 5.16.2 → 5.25.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ tzinfo (indirect, 2.0.5 → 2.0.6) · Repo · Changelog

Release Notes

2.0.6

  • Eliminate Object#untaint deprecation warnings on JRuby 9.4.0.0. #145.

TZInfo v2.0.6 on RubyGems.org

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 9 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.702%. Comparing base (d2b8bcf) to head (3985f0c).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #306   +/-   ##
=========================================
  Coverage   95.702%   95.702%           
=========================================
  Files          311       311           
  Lines         2955      2955           
=========================================
  Hits          2828      2828           
  Misses         127       127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants