-
Notifications
You must be signed in to change notification settings - Fork 755
feat: add env.VAR_NAME support to observability plugin config fields via EnvVarInput and storage normalization
#3577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
BearTS
wants to merge
5
commits into
dev
from
05-19-feat_add_support_for_env_variables_on_certain_fields_in_plugins
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
85fa166
feat(governance): add virtual key blocked models (#3653)
Vaibhav701161 dfa1255
v1.5.4 cut (#3680)
akshaydeo dc124e0
fix: update e2e ui tests (#3687)
sammaji ff463d9
fix: updates mcp oauth api tests (#3693)
sammaji 3839350
feat: add support for env variables on certain fields in plugins
BearTS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| - fix: idle timeout panic in the streaming idle-timeout reader | ||
| - fix: short-circuit `IdleTimeoutReader` reads when the connection is already closed (#3672) | ||
| - fix: preserve tool call stop reason in Anthropic streaming fallback (#3640) (thanks [@dicnunz](https://github.com/dicnunz)!) | ||
| - fix: correct start-time setting for accurate TTFT metric value (#3668) | ||
| - fix: map Vertex traffic type to Bifrost service tier (#3662) | ||
| - fix: ListModels for keyless providers (#3655) | ||
| - fix: remove manual `type: custom` for Anthropic tools (#3652) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| - feat: `created_by` user attribution column for virtual keys (#3672) | ||
| - feat: `blacklisted_models` column for virtual key provider configs (#3653) | ||
| - fix: add monotonic `inc_number` log cursor so node usage reconciliation does not skip late async log writes (#3664) | ||
| - revert: `access_profile_id` direct access profile assignment on virtual keys (#3669) | ||
| - chore: drop the `access_profile_id` column from `governance_virtual_keys` (#3670) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - chore: upgraded core to v1.5.12 and framework to v1.3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| - feat: virtual key blocked-models enforcement — reject requests when the requested model is blocked at the VK provider-config level (#3653) | ||
| - fix: clear stale `governanceRejectedContextKey` on an allow decision so successful fallback retries count toward budgets and rate limits (#3645) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - chore: upgraded core to v1.5.12 and framework to v1.3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - feat: stamp MCP tool logs with governance ownership (user, team, customer, and business unit IDs) from the request context |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - chore: upgraded core to v1.5.12 and framework to v1.3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - chore: upgraded core to v1.5.12 and framework to v1.3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - chore: upgraded core to v1.5.12 and framework to v1.3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - chore: upgraded core to v1.5.12 and framework to v1.3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - chore: upgraded core to v1.5.12 and framework to v1.3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - chore: upgraded core to v1.5.12 and framework to v1.3.12 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"env."prefix causes complete roundtrip failureThe UI's
normalizeEnvVarstrips the"env."prefix from user input (e.g."env.OTEL_COLLECTOR_URL"→{env_var: "OTEL_COLLECTOR_URL"}), soval["env_var"]contains the bare name. The return here produces"OTEL_COLLECTOR_URL"instead of"env.OTEL_COLLECTOR_URL". Every downstream consumer gates onstrings.HasPrefix(val, "env."):denormalizePluginConfigFromStoragewon't expand it back to anEnvVarobject,checkEnvVarsResolvednever fires (makingErrUnresolvedEnvVarsdead code for UI-submitted configs), andschemas.NewEnvVar("OTEL_COLLECTOR_URL")at plugin-init time has no prefix so it returns the literal string"OTEL_COLLECTOR_URL"fromGetValue(), causing the plugin to fail to connect.Fix: change
return envVartoreturn "env." + envVar.