fix(anthropic): normalize tool call continuation deltas#3588
fix(anthropic): normalize tool call continuation deltas#3588punyaslokdutta wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR fixes Anthropic→OpenAI streaming tool-call delta handling by suppressing empty ChangesAnthropic tool-call streaming delta normalization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Confidence Score: 5/5Safe to merge — both changes are narrowly scoped to the streaming conversion path and are guarded by existing nil checks. The two logic changes are small, well-tested, and fix observable protocol mismatches. The empty-delta guard sits inside the already-nil-checked PartialJSON block, and the Type removal only affects continuation chunks where the field is already present on the first chunk. The new tests exercise all three affected code paths directly and would catch regressions. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(anthropic): normalize tool call cont..." | Re-trigger Greptile |
The base branch was changed.
|
@akshaydeo I have signed the license/cla, still "Waiting for status to be reported" |
Summary
tool_calls[].typemetadata on continuation argument chunksTesting
Notes
go test ./providers/anthropic ./providers/vertexstill shows unrelated existinganthropicpackage failures that also reproduce on cleanorigin/main; this PR does not touch those areas.Closes #3443.