Fix Android CI credential injection and rename workflow #3
Conversation
…ency - Implemented Hyper Frames (165Hz) support in `XServerScreen.kt` when using System driver and Adreno Toolkit is disabled. - Refactored `Container.java`, `ShortcutUtils.kt`, and `AndroidManifest.xml` to use dynamic package name (`BuildConfig.APPLICATION_ID`) instead of hardcoded `app.gamenative`. This allows changing the package name (e.g., for system whitelist spoofing) without breaking container paths and shortcuts.
…-fix-15381564544297089281 Add Hyper Frames support and dynamic package name handling
This commit introduces a new workflow `.github/workflows/main_build.yml` to ensure the main branch builds correctly. The workflow: - Triggers on push and pull requests to `master`, and manual dispatch. - Sets up Java 17 and Gradle. - Injects required credentials into `local.properties` (PostHog, Supabase). - Runs `assembleDebug`, `assembleRelease`, and `testDebugUnitTest`. - Uploads the generated Debug and Release APKs as artifacts. This ensures that the codebase is buildable and tests pass.
…1923277173356 Add Main Branch Build Workflow
Renamed main_build.yml to android_ci.yml and updated the workflow name to 'Android CI'. Modified the credential injection step to append secrets to gradle.properties instead of local.properties, ensuring they are correctly loaded as project properties to resolve 'illegal start of expression' build errors. Also renamed the debug workflow in app-release-signed.yml to 'Android CI (Debug)' to avoid naming conflicts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR updates the Android CI workflow to resolve build failures caused by missing credentials.
Changes:
.github/workflows/main_build.ymlto.github/workflows/android_ci.yml.Android CI.gradle.propertiesinstead of overwritinglocal.properties. This ensures that Gradle automatically loads these properties, fixing the "illegal start of expression" error caused by empty or missing property values during build configuration..github/workflows/app-release-signed.ymltoAndroid CI (Debug)to distinguish it from the main release workflow.PR created automatically by Jules for task 3379104801878937897 started by @maxjivi05