-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1432] Opening links from FAQ #1633
base: develop
Are you sure you want to change the base?
Conversation
c7b6bfe
to
e852417
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1633 +/- ##
===========================================
- Coverage 94.20% 94.18% -0.02%
===========================================
Files 1086 1086
Lines 40026 40033 +7
===========================================
Hits 37705 37705
- Misses 2321 2328 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes:
- Change the underline/text-decoration. External links with an icon should only have their text itself be underlined, there should not be a line under the icon itself. For an example, look at the product pages, like this one https://open-inwoner-test.maykin.nl/onderwerpen/zorg-en-ondersteuning/producten/huiselijk-geweld/ that contains external links with proper icons and proper text-decoration:
- Slightly better process when creating a new PR: first switch back to Develop branch, then do a
git pull
, and then create a new branch from Develop. This way you will have a correct commit history. When a task takes longer you can just rebase to Develop, before doing your final commit and only then ask for review. - Add a link to your PR in the Taiga issue as well.
@jiro @linssen814 Note that this PR is based on an older user story and seems to be in tension with the recent https://taiga.maykinmedia.nl/project/open-inwoner/us/3014 (PR: #1631), which requires that links to formulieren and acties be opened in a new tab. The rationale is that otherwise users get the wrong impression that closing the tab will destroy their OIP session (which is not the case because they will log in via an external service to create/resume a form, thus closing the tab will destroy that session but not their OIP session). |
bd93b2d
to
88cb969
Compare
88cb969
to
a1c4603
Compare
Edited
utils/ckeditor.py
so that the links on the FAQ answers don't open in a new tab anymore. Also added link icons to them.Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/1432