Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 [#3059] Refactoring of searchpage grids #1638

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin changed the title 🚧 [#3059] Reconstruction of all searchpage grids 🚧 [#3059] Refactoring of searchpage grids Feb 25, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (f76f455) to head (c6b057c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1638   +/-   ##
========================================
  Coverage    94.20%   94.20%           
========================================
  Files         1086     1086           
  Lines        40026    40026           
========================================
  Hits         37705    37705           
  Misses        2321     2321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin marked this pull request as ready for review February 25, 2025 12:16
@jiromaykin
Copy link
Contributor Author

@stefrado I tried a CSS only solution first, but that won't work, since it's grids-inside-grids-inside grids...
+the Grids need to respond to having filters set on/off by municipalities, so this refactoring into columns might be the better solution. Other pages won't have this problem with multiple grids, but feel free to suggest better!

@jiromaykin jiromaykin requested a review from stefrado February 25, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants