-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/6 meertalige content #34
Conversation
a7deec2
to
634cc12
Compare
c26b76e
to
289b3ab
Compare
The actual package Currently npm run build calls collect (similar to how Open Inwoner does it) that copies the js file from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks mostly fine.
- You could probably make the language API language simpler.
- It is possible to create translations for unsupported language.
- Content Label is not accessible via the API and is missing from the default admin index
default="", | ||
help_text=_("Korte samenvatting van het product type."), | ||
), | ||
naam=models.CharField( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will throw str after migrating since neither will be defined but I guess if no one has an existing DB, it should be fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in my product change page threw an exception because of this
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Changes