Skip to content

Test worldgen changes #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

edayot
Copy link
Contributor

@edayot edayot commented Aug 7, 2024

This PR goes with the one on pytest-insta (do not approve it yet, the tests don't pass btw).

This fix that NamespaceFile that are added with plugins (such as worldgen ones), weren't called in the pytest plugin, now we can customize this.

@edayot edayot marked this pull request as ready for review August 7, 2024 10:29
@vberlier
Copy link
Member

vberlier commented Aug 8, 2024

Good point, I think for worldgen specifically we can enable it by default for data pack snapshots (699c4c3). I released this in beet v0.108.4.

However for the more general case, I'd probably just register another Fmt that configures the pack differently before loading.

@vberlier vberlier closed this Aug 8, 2024
@edayot edayot deleted the test_worldgen_changes branch August 8, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants