Use github actions to automatically run tests#16
Use github actions to automatically run tests#16asedeno wants to merge 1 commit intomchaput:mainfrom
Conversation
227da0b to
a0a27ca
Compare
a0a27ca to
f395d8c
Compare
|
@asedeno this is great! I can see that https://github.com/asedeno/whoosh/actions/runs/943788205 runs clean. @mchaput this looks like a quick win to merge and have automatic feedback on testsuite runs on multiple python versions. |
|
If this gets merged, it should be followed up with an update to the python versions it tests with. I'd recommend removing 3.5 and 3.6, and adding 3.10 and 3.11. |
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Looks pretty good, it is only a bit behind meanwhile because this is rotting here since quite a while, so a few minor updates could be done before merging this.
Don't understand why this is not yet merged.
Having CI feedback for all supported python versions is pretty essential for a project.
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9] |
There was a problem hiding this comment.
| python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9] | |
| python-version: [3.8, 3.9, "3.10", 3.11, 3.12] |
| - uses: actions/checkout@v2 | ||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v2 |
There was a problem hiding this comment.
should be updated to:
actions/checkout@v3
actions/setup-python@v4
There was a problem hiding this comment.
| - uses: actions/checkout@v2 | |
| - name: Set up Python ${{ matrix.python-version }} | |
| uses: actions/setup-python@v2 | |
| - uses: actions/checkout@v4 | |
| - name: Set up Python ${{ matrix.python-version }} | |
| uses: actions/setup-python@v5 |
| pip install pytest nose coverage cached-property | ||
| python setup.py clean build install | ||
| - name: Run test | ||
| run: nosetests --with-coverage |
There was a problem hiding this comment.
Hmm, this is different from what tox.ini is using. Which way is better?
| pip install pytest nose coverage cached-property | ||
| python setup.py clean build install | ||
| - name: Run test | ||
| run: nosetests --with-coverage |
There was a problem hiding this comment.
| pip install pytest nose coverage cached-property | |
| python setup.py clean build install | |
| - name: Run test | |
| run: nosetests --with-coverage | |
| pip install pytest pytest-cov coverage cached-property | |
| python setup.py clean build install | |
| - name: Run test | |
| run: pytest |
nose stopped working around Python 3.8.
Correct FP rounding errors
No description provided.