Open
Conversation
Fixed boost missing in ambiguous date queries Fices incorrect value in RangeNode.has_boost
SnowyCoder
changed the title
cclauss
pushed a commit
to cclauss/whoosh-1
that referenced
this pull request
Jan 4, 2024
Have Git ignore distribution/packaging files.
|
I think this needs tests. |
Author
|
I'm sorry, this was just an issue I found 2 years ago during an exam project, I'm not that much familiar with whoosh code now. |
|
@SnowyCoder we are trying to revive Whoosh with a fork we made and, we are trying to improve the tests and other things to avoid issues like this. In case you want to check it out, here is the fork link. I know you said you are not familiar with the whoosh code and, you are not using it anymore but if you do start to use it feel free to open there any issues you find so we can take a look at them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, while writing a project I noticed some bugs in boost handling in range/date parsing