feat: Add login button #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyu0227
requested review from
claireche89,
joshmhanson and
wilsonplau
as code owners
wilsonplau
reviewed
May 9, 2021
There was a problem hiding this comment.
Just a few notes:
- The
yarn.lockfile should stay committed. It's used to keep all of our versions consistent: https://classic.yarnpkg.com/en/docs/yarn-lock/ - Could you check your
prettiersettings for me? I thought I had set it up in the.ideasettings to auto format on save, but it doesn't seem to work. That way, we can avoid some of the formatting inconsistencies I can see in this PR. - Again, it would be best practice to separate unrelated features into a separate PR. (The
application-dev.propertieschange)
|
joshmhanson
reviewed
May 14, 2021
| spring.jpa.hibernate.ddl-auto=create | ||
| spring.jpa.database-platform=org.hibernate.dialect.PostgreSQLDialect | ||
| spring.datasource.url=jdbc:postgresql://localhost:5432/mcitmocks_dev | ||
| spring.datasource.url=jdbc:postgresql://localhost:5432/mcitmocks-dev |
There was a problem hiding this comment.
We had previously changed the database name from mcitmocks-dev to mcitmocks_dev. Why is this being changed back?
Edit: here's where we originally changed it: d7ee341
claireche89
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What new features or functions does this PR provide? What bugs does it fix?
Testing
How did you test the code in the pull request?
Checklist