Skip to content

feat(oxlint): defer more oxlint config to categories - #24

Merged
mcous merged 1 commit into
mainfrom
feat/oxlint-categories
Jun 5, 2026
Merged

mcous merged 1 commit into
mainfrom
feat/oxlint-categories

Conversation

@mcous

@mcous mcous commented Jun 5, 2026

Copy link
Copy Markdown
Owner

In the same spirit as my ESLint config, this PR takes a pass at reducing my oxlint config to defer to builtin categories as much as possible

This results in a handful of new rules turning on, so this PR also fixes violations in this repo

@coderabbitai

coderabbitai Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d7cec53-0482-40ef-a774-5845c51c7703

📥 Commits

Reviewing files that changed from the base of the PR and between 6539a63 and b9127ed.

📒 Files selected for processing (8)
  • packages/create/oxlint.config.ts
  • packages/create/src/copy-configs.ts
  • packages/create/src/create-manifest.ts
  • packages/create/src/fetch-package-versions.ts
  • packages/create/src/read-manifest.ts
  • packages/oxc-config/package.json
  • packages/oxc-config/src/lint.ts
  • tsconfig.json

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Curated and reorganized linting rules grouped by correctness, performance, and best practices.
  • Improvements

    • Enhanced TypeScript configuration to support importing files with .ts extensions.
    • Refined test file linting overrides for improved development workflows.
  • Chores

    • Released oxc-config v0.2.0 with updated rule sets.

Walkthrough

The PR refactors the root oxlint configuration with a curated ruleset grouped by category (correctness, perf, suspicious, pedantic, restriction, nursery), updates package versioning and tooling configuration, adds a create package-specific oxlint config that disables unsafe-type-assertion, enables TypeScript to import .ts extensions, and improves four create utilities with clearer null checks and type initialization.

Changes

Linting Configuration and Code Quality Updates

Layer / File(s) Summary
Root oxlint rules refactoring
packages/oxc-config/src/lint.ts
The main oxlint configuration replaces a large prior ruleset with a smaller curated set grouped by correctness, perf, suspicious, pedantic, restriction, and nursery categories. Plugin configuration is adjusted, and test file overrides are updated to relax TypeScript unsafe/non-null assertion rules while refining Vitest checks.
Package and tooling configuration updates
packages/oxc-config/package.json, packages/create/oxlint.config.ts, tsconfig.json
Package version bumps to 0.2.0, a new create package oxlint config extends the root and disables typescript/no-unsafe-type-assertion, and TypeScript compiler adds allowImportingTsExtensions to support .ts extension imports.
Create package utility improvements
packages/create/src/fetch-package-versions.ts, packages/create/src/read-manifest.ts, packages/create/src/copy-configs.ts, packages/create/src/create-manifest.ts
Four utilities are improved for clarity and correctness: explicit null check replaces falsy check in version resolution, manifest reader initializes contents as empty string with clearer typing, config copier uses descriptive variable naming, and manifest creator simplifies callback form.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows the Conventional Commits format with 'feat' type prefix and is clearly related to the main changes involving oxlint configuration refactoring.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for deferring to oxlint categories and mentioning that rule violations were fixed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mcous
mcous merged commit ccd055a into main Jun 5, 2026
4 checks passed
@mcous
mcous deleted the feat/oxlint-categories branch June 5, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant