Fix INSTALL_DIR override syntax in docs and install.sh#2
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/mcp-shark/lazy-tool/sessions/3f264d0c-7da0-4807-b8f0-f352bdd7bc91 Co-authored-by: rpgeeganage <10336353+rpgeeganage@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update install command for overriding default behavior
Fix INSTALL_DIR override syntax in docs and install.sh
Apr 7, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rpgeeganage
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
INSTALL_DIRbeforecurlpasses it to the downloader process, not to theshinterpreter that runs the script — so the override had no effect.Changes
README.md– Fix override example soINSTALL_DIRis passed toshinstall.sh– Fix usage comment to match correct syntaxBefore (broken):
After (correct):