fix: make source_ids schema provider-compatible#4
Merged
rpgeeganage merged 1 commit intoMay 10, 2026
Merged
Conversation
Expose search_tools source_ids as an optional array instead of a nullable union so MCP clients that adapt tools to provider function declarations can accept the schema.
Member
|
Thank you for the contribution 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search_tools.source_idsas an optional plain array schema instead of a nullable unionsource_idswhen unusedarrayWhy
The previous generated schema used
type: ["null", "array"]. That is valid JSON Schema, but some MCP clients and provider function-declaration adapters reject nullable union types for tool parameters. Sincesource_idsis optional, it does not need to includenullin the schema type.This improves compatibility for clients that translate MCP tools into provider function declarations while preserving the existing optional argument behavior.
Verification
go test ./internal/mcpserver -run TestSearchToolsInputSchema_SourceIDsIsArraygo test ./...