-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data points for nested pseudo-elements #26240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this rather go under css.selectors.marker
?
"description": "`::marker`", |
Possibly both, but not either, imo. |
Requesting a second opinion from @Elchi3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM what Chris did here.
We could also add it to ::marker but I have no strong opinion. The chromestatus also says that ::column will get it in the future, so I think always adding it to the selectors that gain support for it makes sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is potentially a new web-feature. Let's keep the decision for web-feature maintainers and not add tags for now.
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Sounds good; cheers @Elchi3! |
Summary
Chrome has added support for styling nested pseudo-elements, beginning in version 135 with
::after::marker
and::before::marker
. See https://chromestatus.com/feature/5199947786616832.This PR adds a data point for each of those two.
Test results and supporting details
Related issues