Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data points for nested pseudo-elements #26240

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

chrisdavidmills
Copy link
Contributor

Summary

Chrome has added support for styling nested pseudo-elements, beginning in version 135 with ::after::marker and ::before::marker. See https://chromestatus.com/feature/5199947786616832.

This PR adds a data point for each of those two.

Test results and supporting details

Related issues

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed labels Mar 17, 2025
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this rather go under css.selectors.marker?

"description": "`::marker`",

@chrisdavidmills
Copy link
Contributor Author

Shouldn't this rather go under css.selectors.marker?

"description": "`::marker`",

Possibly both, but not either, imo.

@caugner
Copy link
Contributor

caugner commented Mar 20, 2025

Requesting a second opinion from @Elchi3.

@caugner caugner requested a review from Elchi3 March 25, 2025 16:44
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM what Chris did here.
We could also add it to ::marker but I have no strong opinion. The chromestatus also says that ::column will get it in the future, so I think always adding it to the selectors that gain support for it makes sense to me.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is potentially a new web-feature. Let's keep the decision for web-feature maintainers and not add tags for now.

@chrisdavidmills
Copy link
Contributor Author

I think this is potentially a new web-feature. Let's keep the decision for web-feature maintainers and not add tags for now.

Sounds good; cheers @Elchi3!

@Elchi3 Elchi3 merged commit 3a0f2e2 into mdn:main Apr 1, 2025
5 checks passed
@mdn-bot mdn-bot mentioned this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants