fix(learn): Cross browser testing - correct misleading text

[ShamarYarde]

Previous text implied that driver.executeScript("lambda-status=passed"); and driver.executeScript("lambda-status=failed"); should be ran inside a Bash terminal shell instead of inside added inside the lambdatest_google_test.js demo code.

Running either as a command in a Bash terminal shell results in the following:

bash: syntax error near unexpected token `"lambda-status=passed"'

if

driver.executeScript("lambda-status=passed");

is ran, and

bash: syntax error near unexpected token `"lambda-status=failed"'

if

driver.executeScript("lambda-status=failed");

is ran.

Adding either within the lambdatest_google_test.js demo code produces respective results on the LambdaTest Automation dashboard. Also, it looks like these should be inside if and else blocks of code.

Description

Changed explanatory text to indicate where code should be placed.

Motivation

To allow readers to understand how to mark a test an automation test's status as passed or failed. Also, to remove confusion on where to look to make changes in the Your own remote server section.

Additional details

Related issues and pull requests

"Fixes #31074"

[github-actions]

Preview URLs

• /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment

External URLs (1)

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment
Title: Setting up your own test automation environment

• https://www.lambdatest.com/blog/wp-content/uploads/2019/02/Automation-logs-1.jpg (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-02-16 01:42:52)

[hamishwillee]

I'd propose putting these in the example above so that there is no doubt about where they go. Then delete this section and add an explanation below step 5 in the previous section about what this code does.

But perhaps do it in the other PR so that we're only working on one PR per document.

[ShamarYarde]

I added it here, because the refactored code and updated tutorial text to reflect changes was merged by the time I got back.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[ShamarYarde]

Lines of code moved to lambdatest_google_test.js example to remove confusion.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[ShamarYarde]

@hamishwillee I ran out of minutes, so I'm not able to fix the sauce_google_test.js example in the Filling in Sauce Labs test details programmatically section, but it looks like it's missing the username in the saucelabs' updateJob method call and the driver.sessionID is undefined.

[hamishwillee]

@ShamarYarde Sorry for the delay - this wasn't initially assigned to me, and I missed the notification when it was. Will look now.

[hamishwillee]

@ShamarYarde So what you've done is moved the stuff about marking tests as passed or failed from the separate section Filling in test details on LambdaTest programmatically into the body of the main example. Reading that deleted section assumed you'd update the example code, not enter in bash.

That said, I think doing it this way is actually reasonable - there isn't a particular need to highlight this option separately in its own section - in fact by putting it in the body of the example you could argue it makes this something that people are more likely to do by default.

[hamishwillee]

I ran out of minutes, so I'm not able to fix the sauce_google_test.js example in the Filling in Sauce Labs test details programmatically section, but it looks like it's missing the username in the saucelabs' updateJob method call and the driver.sessionID is undefined.

@ShamarYarde I'm going to merge this PR. Do you think you now have bandwidth to look at this case ^^^

[hamishwillee]

Thanks very much!!!

[ShamarYarde]

I ran out of minutes, so I'm not able to fix the sauce_google_test.js example in the Filling in Sauce Labs test details programmatically section, but it looks like it's missing the username in the saucelabs' updateJob method call and the driver.sessionID is undefined.

@ShamarYarde I'm going to merge this PR. Do you think you now have bandwidth to look at this case ^^^

@hamishwillee No, I'm still out of minutes. I don't have a subscription.

[hamishwillee]

Thanks @ShamarYarde - I've created an issue to track the missing bit in #32401 - does that look about right?

As an aside though

• you know the user name needs to exist in the updateJob method, so wouldn't it be best to update the docs indicating some value, even if we can't verify it? I.e. no worse than it is now.
• You say "driver.sessionID is undefined" - can you expand on what you think needs to happen in the docs?

[ShamarYarde]

@hamishwillee I don't remember what I saw when I tried it, but it wasn't working. I just looked at the code I have, and the following lines were commented out which means that they were causing the error I was getting:

saucelabs.updateJob(username, get_session_id(), {
      name: "Google search results page title test",
      passed: testPassed,
})

The response when I run the command: node sauce_google_test.js now is the following:

/.../selenium-test/node_modules/selenium-webdriver/lib/error.js:558
        throw new ctor(message)
              ^

WebDriverError: Uh oh, you've run out of minutes!
Please visit https://saucelabs.com/pricing to purchase a subscription.
    at Object.checkLegacyResponse (/.../selenium-test/node_modules/selenium-webdriver/lib/error.js:558:15)
    at parseHttpResponse (/.../selenium-test/node_modules/selenium-webdriver/lib/http.js:593:13)
    at Executor.execute (/.../selenium-test/node_modules/selenium-webdriver/lib/http.js:529:28)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  remoteStacktrace: ''
}

Node.js v20.11.0

[hamishwillee]

Thanks!