Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF122 Relnote HTMLSelectElement.showPicker #31133

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

hamishwillee
Copy link
Collaborator

FF122 enabled support for Relnote HTMLSelectElement.showPicker() in https://bugzilla.mozilla.org/show_bug.cgi?id=1865207. This adds release note, and removes form experimental features.

Related docs work can be tracked in #31106

@hamishwillee hamishwillee requested a review from a team as a code owner December 18, 2023 23:27
@hamishwillee hamishwillee requested review from zfox23 and removed request for a team December 18, 2023 23:27
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Dec 18, 2023
Copy link
Contributor

github-actions bot commented Dec 18, 2023

Preview URLs

External URLs (76)

URL: /en-US/docs/Mozilla/Firefox/Releases/122
Title: Firefox 122 for developers


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-01-02 03:20:55)

zfox23
zfox23 previously requested changes Dec 19, 2023
Copy link
Contributor

@zfox23 zfox23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! one minor formatting suggestion.

@mdn mdn deleted a comment from Arumankumang Dec 21, 2023
@hamishwillee hamishwillee requested a review from zfox23 December 22, 2023 08:41
@hamishwillee hamishwillee dismissed zfox23’s stale review December 27, 2023 00:18

IMO it's invalid/inconsistent. But leaving the comment open so @zfox23 can respond.

@hamishwillee hamishwillee force-pushed the ff122_selectelement_showpicker branch from 7cecef8 to 0e4271e Compare January 2, 2024 03:19
@bsmth bsmth requested review from bsmth and removed request for zfox23 January 9, 2024 10:37
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍🏻

@bsmth bsmth merged commit 40b505f into mdn:main Jan 9, 2024
7 checks passed
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@hamishwillee hamishwillee deleted the ff122_selectelement_showpicker branch January 25, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants