added example of hr in select #31169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dletorey
requested review from
chrisdavidmills
and removed request for
a team
|
Preview URLs (comment last updated: 2023-12-21 14:55:00) |
This was referenced Dec 20, 2023
estelle
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Recently, there has been a conversation about the accessibility of <hr> in selects. See https://adrianroselli.com/2023/10/splitting-within-selects.html. We likely should add an "accessibility concerns" section, and state something to the effect of "The <hr> should be considered purely decorative, as they are currently not exposed within the accessibility tree and therefore not exposed to assistive technologies".
I also found https://a11ysupport.io/tests/tech__html__select for select a11y issues other than hr, which may be helpful. It predates the inclusion of hr.
estelle
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Reviewed. Three suggestions:
- Include the hr as part of the list of descendants, not under its own heading (I suggested a paragraph)
- Add and a11y concerns section (resources provided in comments)
- In the example, change the label to be the purpose of the form control and the default value to text that demonstrates a value as not yet been selected.
optional 4th edit:
- header text for the example
Co-authored-by: Estelle Weyl <[email protected]>
…t into 31109-hr-in-select
estelle
approved these changes
Dec 22, 2023
dipikabh
pushed a commit
to dipikabh/content
that referenced
this pull request
Jan 17, 2024
* added example of hr in select and note about it and link to select from hr page * Update files/en-us/web/html/element/select/index.md Co-authored-by: Estelle Weyl <[email protected]> * changed the order of the content and added a11y concerns section --------- Co-authored-by: Estelle Weyl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<hr>in<select><hr>in<select><hr>as permitted child of<select><hr>page to the select element pageMotivation
Working on issue 31109
Related issues and pull requests