Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing xlink to the simplified structure code #37900

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

mohanad-80
Copy link
Contributor

Description

Added the missing CSS file link in the simplified structure code for the SVG example.

Motivation

Additional details

I tested the code before and after the changes.
Before the fix: The SVG and the page were missing styles.
After the fix: The SVG and page now have proper styles and colors. However, as mentioned in the documentation, the hover does not work consistently across all browsers.

Related issues and pull requests

Fixes #37757

@mohanad-80 mohanad-80 requested a review from a team as a code owner January 31, 2025 16:07
@mohanad-80 mohanad-80 requested review from hamishwillee and removed request for a team January 31, 2025 16:07
@github-actions github-actions bot added Content:SVG SVG docs size/s [PR only] 6-50 LoC changed labels Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Preview URLs

(comment last updated: 2025-01-31 16:58:16)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks

@Josh-Cena Josh-Cena merged commit 1cb66a2 into mdn:main Jan 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:SVG SVG docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing xlink to SVG simplified example
2 participants