-
Notifications
You must be signed in to change notification settings - Fork 22.7k
Replace some w3.org/TR links with editor drafts #39683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Josh-Cena.
I've pointed a few nits and suggestions. Leaving a +1.
Since the August 29, 2014, [Web Audio API specification](https://www.w3.org/TR/webaudio/#ScriptProcessorNode) publication, this feature has been deprecated. It is no longer on track to become a standard. | ||
|
||
It was replaced by [AudioWorklets](/en-US/docs/Web/API/AudioWorklet) and the {{domxref("AudioWorkletNode")}} interface. | ||
{{Specifications}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rendering a "No specification found" error.
There's no spec_url
in BCD: https://github.com/mdn/browser-compat-data/blob/3631af310c4a737ae57a93199c34dc4bd2a48079/api/ScriptProcessorNode.json#L38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a BCD bug because https://developer.mozilla.org/en-US/docs/Web/API/ScriptProcessorNode/bufferSize does have a spec link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it has to be in https://github.com/w3c/browser-specs/blob/main/specs.json
See https://redirect.github.com/w3c/browser-specs/pull/1571 for last time I was adding a missing spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, it's just missing BCD keys. Let's follow the issue because https://webaudio.github.io/web-audio-api/#dom-scriptprocessornode-onaudioprocess is as close as I can find for a definition. Maybe not worth diving too deep into it as it's deprecated anyway.
Co-authored-by: Dipika Bhattacharya <[email protected]>
Any objections to merging like this? |
I've left another #39683 (comment). Other than that, good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
Part of #36615