Skip to content

Conversation

@bsmth
Copy link
Member

@bsmth bsmth commented Sep 2, 2025

Description

We have another case where we're describing specificity, @scope and &. Removing the duplication and pointing to browser compat

Motivation

We have conflicting info, specs are updated and it looks like Fx142 is the only browser to make default behavior spec-compliant.

Related issues and pull requests

Fixes #40981

@bsmth bsmth requested a review from a team as a code owner September 2, 2025 11:38
@bsmth bsmth requested review from estelle and removed request for a team September 2, 2025 11:38
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Preview URLs

Flaws (3)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/@scope
Title: @scope
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/scope-start
    • Can't resolve /en-US/docs/Web/CSS/scope-end
    • Can't resolve /en-US/docs/Web/CSS/block-contents
External URLs (1)

URL: /en-US/docs/Web/CSS/@scope
Title: @scope

(comment last updated: 2025-09-11 09:22:42)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is this appropriate here:

browser-compat:
  - css.at-rules.scope
  - css.selectors.nesting.at-scope

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the css.selectors.nesting.at-scope data to css..at-rules.scope, but, yes, definitely add especially if the top & part doesn't show, but would be better to have one table instead of two.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the extra entry in c9ad1f5

css.selectors.nesting.at-scope data to css.at-rules.scope

Do you mean we should move it in BCD or duplicate the entry to be in both places there? It's tricky to decide where it should live, my first thoughts were that it's specific to &.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate it, as i think it's a bug in both

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Lots of suggestions, but they're all minor (suggesting links mostly)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the css.selectors.nesting.at-scope data to css..at-rules.scope, but, yes, definitely add especially if the top & part doesn't show, but would be better to have one table instead of two.

@estelle
Copy link
Member

estelle commented Sep 11, 2025

@bsmth are you still reviewing this, or should i re-review?

@bsmth
Copy link
Member Author

bsmth commented Sep 11, 2025

@bsmth are you still reviewing this, or should i re-review?

Thanks for checking, I'll push some of the suggestions and re-request review shortly 👍🏻

@bsmth bsmth requested a review from estelle September 11, 2025 09:23
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 943a9ba into mdn:main Sep 11, 2025
8 checks passed
@bsmth bsmth deleted the 40981-ampersand-at-scope branch September 11, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong information for the selector &

2 participants