-
Notifications
You must be signed in to change notification settings - Fork 23k
content(Fx142): & inside at-scope blocks has no implicit specificity #40983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview URLs Flaws (3)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
External URLs (1)URL:
(comment last updated: 2025-09-11 09:22:42) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Is this appropriate here:
browser-compat:
- css.at-rules.scope
- css.selectors.nesting.at-scopeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add the css.selectors.nesting.at-scope data to css..at-rules.scope, but, yes, definitely add especially if the top & part doesn't show, but would be better to have one table instead of two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the extra entry in c9ad1f5
css.selectors.nesting.at-scope data to css.at-rules.scope
Do you mean we should move it in BCD or duplicate the entry to be in both places there? It's tricky to decide where it should live, my first thoughts were that it's specific to &.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate it, as i think it's a bug in both
estelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Lots of suggestions, but they're all minor (suggesting links mostly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add the css.selectors.nesting.at-scope data to css..at-rules.scope, but, yes, definitely add especially if the top & part doesn't show, but would be better to have one table instead of two.
Co-authored-by: Estelle Weyl <[email protected]>
|
@bsmth are you still reviewing this, or should i re-review? |
Thanks for checking, I'll push some of the suggestions and re-request review shortly 👍🏻 |
estelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Description
We have another case where we're describing specificity,
@scopeand&. Removing the duplication and pointing to browser compatMotivation
We have conflicting info, specs are updated and it looks like Fx142 is the only browser to make default behavior spec-compliant.
Related issues and pull requests
&behaviour inside@scopeblock as per spec resolution #40481&as:where(:scope)in@scopeblocks browser-compat-data#27723Fixes #40981