Conversation
github-actions
Bot
added
Content:PWA
Contributor
|
Preview URLs (3 pages)
External URLs (1)URL:
(comment last updated: 2026-04-30 07:35:36) |
hamishwillee
approved these changes
May 1, 2026
Collaborator
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
@estelle Looks good.
Approving but not merging, so you can merge when you think best - now or when the associated example repo PRs merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because the PWA cycle tracker example is in a github subdirectory, the root relative links were creating 404's. this handles that, and, along with mdn/pwa-examples#44, fixes mdn/pwa-examples#39