Force system wide python module installs if needed.#397
Open
sonoransun wants to merge 2 commits intodevelopfrom
Open
Force system wide python module installs if needed.#397sonoransun wants to merge 2 commits intodevelopfrom
sonoransun wants to merge 2 commits intodevelopfrom
Conversation
sonoransun
requested review from
DGaffney,
computermacgyver and
skyemeedan
as code owners
|
Code Climate has analyzed commit 9890023 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.9% (0.0% change). View more on Code Climate. |
skyemeedan
approved these changes
Apr 26, 2024
Contributor
skyemeedan
left a comment
skyemeedan
left a comment
There was a problem hiding this comment.
seems like a great work around! I wonder if there are base images we could use that already have the AWS utils installed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While debugging GitLab CI issues, it was observed that the Alegre builds were failing when attempting to install the awscli (or other pip modules).
How has this been tested?
A build and deploy from this branch confirmed the fix.
Have you considered secure coding practices when writing this code?
There are no security concerns with this change, as we previously performed system wide installations of pip modules and utiltiies.